Skip to content

fix: TinyMCE editor in advanced block editors [FC-0076] (#36754) - #36772

Merged
pomegranited merged 1 commit into
openedx:release/teakfrom
open-craft:chris/teak/fix-tinymce-in-advanced-editors
May 22, 2025
Merged

fix: TinyMCE editor in advanced block editors [FC-0076] (#36754)#36772
pomegranited merged 1 commit into
openedx:release/teakfrom
open-craft:chris/teak/fix-tinymce-in-advanced-editors

Conversation

@ChrisChV

@ChrisChV ChrisChV commented May 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Backport of #36754

Supporting information

Testing instructions

Follow the testing instruction on #36754

Deadline

ASAP

Other information

N/A

@ChrisChV
fix: TinyMCE editor in advanced block editors [FC-0076] (openedx#36754)
ec5f558 
* fix: TinyMCE editors in advanced block editors
* Sets baseUrl to avoid an error in: https://github.com/openedx/XBlock/blob/86eee4b05dffa42b009fab2a9050b73766131b9d/xblock/utils/public/studio_edit.js#L52
* Uncouple the listener func of the cancel button (see the comment)
* chore: Add `edx_sga` in `LIBRARY_ENABLED_BLOCKS`
@openedx-webhooks

openedx-webhooks commented May 22, 2025

Copy link
Copy Markdown

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 22, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions May 22, 2025
pomegranited
pomegranited approved these changes May 22, 2025
View reviewed changes

@pomegranited pomegranited left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this on my devstack using the teak branch of Authoring MFE
  • I read the commit to check that it matches the original merged #36754

@pomegranited
pomegranited merged commit 4146b3c into openedx:release/teak May 22, 2025
@pomegranited
pomegranited deleted the chris/teak/fix-tinymce-in-advanced-editors branch May 22, 2025 01:40
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions May 22, 2025
Copilot AI pushed a commit to AhtishamShahid/edx-platform that referenced this pull request Mar 4, 2026
@ChrisChV @AhtishamShahid
fix: TinyMCE editor in advanced block editors [FC-0076] (openedx#36754)…
761b3ad 
… (openedx#36772)

* fix: TinyMCE editors in advanced block editors
* Sets baseUrl to avoid an error in: https://github.com/openedx/XBlock/blob/86eee4b05dffa42b009fab2a9050b73766131b9d/xblock/utils/public/studio_edit.js#L52
* Uncouple the listener func of the cancel button (see the comment)
* chore: Add `edx_sga` in `LIBRARY_ENABLED_BLOCKS`

(cherry picked from commit 4146b3c)
This was referenced Mar 4, 2026
Draft
Draft
Copilot AI pushed a commit to AhtishamShahid/edx-platform that referenced this pull request Mar 4, 2026
@ChrisChV
fix: TinyMCE editor in advanced block editors [FC-0076] (openedx#36754)…
79b0ddc 
… (openedx#36772)

* fix: TinyMCE editors in advanced block editors
* Sets baseUrl to avoid an error in: https://github.com/openedx/XBlock/blob/86eee4b05dffa42b009fab2a9050b73766131b9d/xblock/utils/public/studio_edit.js#L52
* Uncouple the listener func of the cancel button (see the comment)
* chore: Add `edx_sga` in `LIBRARY_ENABLED_BLOCKS`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pomegranited pomegranited pomegranited approved these changes

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChrisChV @openedx-webhooks @pomegranited