Use new feedback notification when changing section release dates. - #366
Conversation
|
Failing tests:
|
|
Forgot to remove |
There was a problem hiding this comment.
Do you want to keep the hellip; inside the localizable string? This might be confusing to translators? Maybe a string concatenation would be preferable?
There was a problem hiding this comment.
I agree it might be confusing. We've done it in numerous places though. If Peter changes this one, he should change them all.
Perhaps "Saving" should store some common text options (or use Saving.... as the default value).
There was a problem hiding this comment.
Since we're changing the Saving type to Mini, I'm not sure if it would make sense to use "Saving..." as the default value. I'll take the ellipsis out of the gettext call; it only occurs in two places.
|
👍 |
Use new feedback notification when changing section release dates.
…cohort-menu Hide "Visible To" dropdown for non-cohorted inline discussions
…bmit-on-save Disable submit button on save click
* fix: set default copyright to 'creative common by share alike' * fix: update display text for share alike copyright
Also remove the old flashing animation on save.