Skip to content

Use new feedback notification when changing section release dates. - #366

Merged
peter-fogg merged 4 commits into
masterfrom
peter-fogg/stud-116
Jul 11, 2013
Merged

Use new feedback notification when changing section release dates.#366
peter-fogg merged 4 commits into
masterfrom
peter-fogg/stud-116

Conversation

@peter-fogg

Copy link
Copy Markdown
Contributor

Also remove the old flashing animation on save.

@chrisndodge

Copy link
Copy Markdown
Contributor

Failing tests:

Course Overview.should save model when save is clicked 77 ms 1
Course Overview.should show a confirmation on save 31 ms 1

@peter-fogg

Copy link
Copy Markdown
Contributor Author

Forgot to remove @xhr, which is undefined. Tests should be passing now.

Comment thread cms/static/js/base.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to keep the hellip; inside the localizable string? This might be confusing to translators? Maybe a string concatenation would be preferable?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it might be confusing. We've done it in numerous places though. If Peter changes this one, he should change them all.

Perhaps "Saving" should store some common text options (or use Saving.... as the default value).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're changing the Saving type to Mini, I'm not sure if it would make sense to use "Saving..." as the default value. I'll take the ellipsis out of the gettext call; it only occurs in two places.

@cahrens

cahrens commented Jul 11, 2013

Copy link
Copy Markdown

👍

peter-fogg pushed a commit that referenced this pull request Jul 11, 2013
Use new feedback notification when changing section release dates.
@peter-fogg
peter-fogg merged commit 42ff1c2 into master Jul 11, 2013
@peter-fogg
peter-fogg deleted the peter-fogg/stud-116 branch July 11, 2013 20:34
antoviaque referenced this pull request in open-craft/openedx-platform Jan 8, 2015
…cohort-menu

Hide "Visible To" dropdown for non-cohorted inline discussions
diegomillan pushed a commit to eduNEXT/edx-platform that referenced this pull request Sep 14, 2016
…bmit-on-save

Disable submit button on save click
idegtiarov pushed a commit to Code-Institute-Org/edx-platform that referenced this pull request Sep 17, 2018
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022
Danyal-Faheem pushed a commit to Danyal-Faheem/edx-platform that referenced this pull request Jul 15, 2025
* fix: set default copyright to 'creative common by share alike'

* fix: update display text for share alike copyright
kiram15 pushed a commit that referenced this pull request Jul 17, 2026
kiram15 pushed a commit that referenced this pull request Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants