Skip to content

chore: iframe rendering optimization - #35959

Merged
arbrandes merged 5 commits into
openedx:masterfrom
raccoongang:Peter_Kulko/rendering-optimization
Feb 11, 2025
Merged

chore: iframe rendering optimization#35959
arbrandes merged 5 commits into
openedx:masterfrom
raccoongang:Peter_Kulko/rendering-optimization

Conversation

@peterkulko

@peterkulko peterkulko commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

🚨 Dependencies:

Description

This PR provides iframe reload optimizations for various xblock related actions. Added some improvements related to scrolling to the current xblock. Fixed behavior of the xblock action dropdown list.

Testing instructions

  1. Open New Course Unit page.
  2. When duplicating a block, a scroll to a new copy of the block occurs.
  3. Delete, duplicate, drag xblock - a full iframe reboot should not occur.
  4. Open a new xblock editor, save the changes - after returning to the course unit page, the page should scroll to the xblock for which the changes were made.
Screen.Recording.2025-01-20.at.9.21.47.AM.mov

Other information

Improvements to the editing modals and tagging will be added in future PRs.

@peterkulko peterkulko self-assigned this Dec 4, 2024
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 4, 2024
@openedx-webhooks

openedx-webhooks commented Dec 4, 2024

Copy link
Copy Markdown

Thanks for the pull request, @PKulkoRaccoonGang!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Comment thread cms/static/js/views/pages/container.js Outdated
Comment thread cms/static/js/views/pages/container.js Outdated
Comment thread cms/static/js/views/pages/container.js
Comment thread cms/static/js/views/pages/container.js Outdated
@peterkulko
peterkulko force-pushed the Peter_Kulko/rendering-optimization branch from 90e61dd to 64c4b07 Compare January 22, 2025 09:41
Comment thread cms/static/js/views/pages/container.js Outdated
@bradenmacdonald

Copy link
Copy Markdown
Contributor

I'm happy with how this PR is looking, but I haven't tested it. I'm assuming @arbrandes will do the final review, but let me know if you want further review or testing from me. Thanks!

@arbrandes arbrandes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed together with openedx/frontend-app-authoring#1544. See the review there for details, but we're good to merge.

@arbrandes
arbrandes merged commit 9257164 into openedx:master Feb 11, 2025
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

jciasenza pushed a commit to jciasenza/edx-platform that referenced this pull request Feb 25, 2025
Iframe reload optimizations for various xblock related actions. Added some improvements related to scrolling to the current xblock. Fixed behavior of the xblock action dropdown list.
tonybusa pushed a commit to tonybusa/edx-platform that referenced this pull request Apr 23, 2025
Iframe reload optimizations for various xblock related actions. Added some improvements related to scrolling to the current xblock. Fixed behavior of the xblock action dropdown list.
UsamaSadiq pushed a commit that referenced this pull request May 14, 2025
Iframe reload optimizations for various xblock related actions. Added some improvements related to scrolling to the current xblock. Fixed behavior of the xblock action dropdown list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants