Skip to content

feat: post message on preview library block changes - #35861

Merged
ChrisChV merged 3 commits into
openedx:masterfrom
open-craft:navin/preview-library-block-iframe
Nov 19, 2024
Merged

feat: post message on preview library block changes#35861
ChrisChV merged 3 commits into
openedx:masterfrom
open-craft:navin/preview-library-block-iframe

Conversation

@navinkarkera

@navinkarkera navinkarkera commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

Description

Posts message with library xblock changes info instead of displaying a modal if the unit is rendered in an iframe.

Depends on #35693 Merged.

Supporting information

Testing instructions

Follow instructions in openedx/frontend-app-authoring#1506

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 15, 2024
@openedx-webhooks

openedx-webhooks commented Nov 15, 2024

Copy link
Copy Markdown

Thanks for the pull request, @navinkarkera!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@rpenido rpenido left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work, @navinkarkera!

@navinkarkera
navinkarkera force-pushed the navin/preview-library-block-iframe branch from af5bc52 to 8f07aa5 Compare November 19, 2024 04:52
@navinkarkera
navinkarkera marked this pull request as ready for review November 19, 2024 04:53
@ChrisChV
ChrisChV enabled auto-merge (squash) November 19, 2024 19:03
@ChrisChV
ChrisChV merged commit 49330a2 into openedx:master Nov 19, 2024
@ChrisChV
ChrisChV deleted the navin/preview-library-block-iframe branch November 19, 2024 19:07
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants