revert: "fix: update course discussion config before course load" - #35349
Merged
Conversation
…)" This reverts commit 5c09424.
KristinAoki
requested review from
AhtishamShahid,
bszabo,
jesperhodge and
rayzhou-bit
August 22, 2024 19:15
rayzhou-bit
approved these changes
Aug 22, 2024
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
rediris
pushed a commit
to gymnasium/edx-platform
that referenced
this pull request
Aug 27, 2024
…edx#35219)" (openedx#35349) This reverts commit 5c09424.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 5c09424.
Description
This change impacts Course Authors. PR #35219 causes 504 errors on large courses. For exploration is needed to determine why
update_discussions_settings_from_coursecauses timeout errors. I am unable to reproduce the error on my local set-up, but based on the timing of the bug and merge of PR the two appear to be linked.Supporting information
JIRA Ticket: TNL-11723 🔒