Make wiki links not look inactive - #3504
Merged
Merged
Conversation
Contributor
|
@davestgermain I would either make the color exactly the same, or give it some more robust "current" state styling - maybe leave the link color the same and add a light gray background - $gray-l4 maybe? If you go that route, it would be nice to add a little more padding to the .nav-tabs a. |
Contributor
Author
|
@frrrances ok, I've made them the same color, added the gray background, and increased the padding. |
Contributor
|
@davestgermain just saw that this never got merged. Looks good though I couldn't get the branch to load so I made a new one: https://github.com/edx/edx-platform/compare/frances/fix/wiki-links Feel free to merge either. 👍 |
davestgermain
pushed a commit
that referenced
this pull request
Jul 10, 2014
Make wiki links not look inactive. Fixes LMS-1308
This was referenced Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@frrrances not sure if
link-color-d1is the most correct color for "active" links, but it looks appropriately different from the base color.fixes LMS-1308