Skip to content

temp: trace celery tasks in dd - #34537

Merged
connorhaugh merged 2 commits into
masterfrom
temp--trace-celery-tasks-in-dd
Apr 18, 2024
Merged

temp: trace celery tasks in dd#34537
connorhaugh merged 2 commits into
masterfrom
temp--trace-celery-tasks-in-dd

Conversation

@connorhaugh

@connorhaugh connorhaugh commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

Description

this PR adds the ability for DD to gather traces in celery tasks, something NR does automatically. I know this is DD specific code, but a long-term solution will be coming soon.

Supporting information

edx/edx-arch-experiments#584

Testing instructions

  1. follow https://2u-internal.atlassian.net/wiki/spaces/~840928901/pages/813793298/OpenTelemetry+New+Relic+and+Datadog for devstack setup for DD, but set up the DD agent on CMS as usual
  2. Follow https://2u-internal.atlassian.net/wiki/spaces/ENGAGE/pages/395673715/How+to+configure+Celery+worker+on+LMS+CMS+Devstack to set up celery workers on cms
  3. Export a course
  4. View the export on DD

Deadline

This will be merged ASAP and reverted no later than 4/22. A revert PR will be linked in this PR soon.

@connorhaugh connorhaugh mentioned this pull request Apr 17, 2024
Closed
1 task
@kdmccormick
kdmccormick self-requested a review April 18, 2024 14:02
kdmccormick
kdmccormick approved these changes Apr 18, 2024
View reviewed changes

@kdmccormick kdmccormick left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good--I hope this gets you the data you need!

Early heads up, I'm not sure how long we'll support temporary 2U-specific commits like this in openedx/edx-platform. Among other benefits, deploying off of a regularly-synced soft fork of edx-platform would free you up to make temp commits without having to run them by us at all.

@connorhaugh
connorhaugh merged commit f866545 into master Apr 18, 2024
@connorhaugh
connorhaugh deleted the temp--trace-celery-tasks-in-dd branch April 18, 2024 17:08
@edx-pipeline-bot

edx-pipeline-bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

edx-pipeline-bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot

edx-pipeline-bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

edx-pipeline-bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

connorhaugh added a commit that referenced this pull request Apr 19, 2024
@connorhaugh
Revert "temp: trace celery tasks in dd (#34537)"
9f26ac9 
This reverts commit f866545.
@connorhaugh connorhaugh mentioned this pull request Apr 19, 2024
Merged
jsnwesson pushed a commit that referenced this pull request Apr 19, 2024
@connorhaugh
Revert "temp: trace celery tasks in dd (#34537)" (#34553)
a7b4416 
This reverts commit f866545.
dianakhuang added a commit that referenced this pull request Apr 22, 2024
@dianakhuang
Revert "Revert "temp: trace celery tasks in dd (#34537)" (#34553)"
dfa322c 
This reverts commit a7b4416.
dianakhuang added a commit that referenced this pull request Apr 22, 2024
@dianakhuang
Revert "Revert "temp: trace celery tasks in dd"" (#34563)
ebe36a2 
* Revert "Revert "temp: trace celery tasks in dd (#34537)" (#34553)"

This reverts commit a7b4416.

* docs: Update removal date on temporary celery flag.
KyryloKireiev pushed a commit to raccoongang/edx-platform that referenced this pull request Apr 24, 2024
@connorhaugh @KyryloKireiev
temp: trace celery tasks in dd (openedx#34537)
405b64a
KyryloKireiev pushed a commit to raccoongang/edx-platform that referenced this pull request Apr 24, 2024
@connorhaugh @KyryloKireiev
Revert "temp: trace celery tasks in dd (openedx#34537)" (openedx#34553)
bd1e41c 
This reverts commit f866545.
KyryloKireiev pushed a commit to raccoongang/edx-platform that referenced this pull request Apr 24, 2024
@dianakhuang @KyryloKireiev
Revert "Revert "temp: trace celery tasks in dd"" (openedx#34563)
892b4fb 
* Revert "Revert "temp: trace celery tasks in dd (openedx#34537)" (openedx#34553)"

This reverts commit a7b4416.

* docs: Update removal date on temporary celery flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dianakhuang dianakhuang dianakhuang approved these changes
@kdmccormick kdmccormick kdmccormick approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@connorhaugh @edx-pipeline-bot @dianakhuang @kdmccormick