fix: Space around techers images on course about page - #34357
Conversation
|
Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
sarina
left a comment
There was a problem hiding this comment.
Hi @Lunyachek this change makes sense to me.
We follow a rebasing workflow. Could I ask you to please rebase your branch atop Master, and when you use GitHub's update branch feature in the future, change it to use rebasing instead of merging master.
Please ping me when the rebase is good to go!
444693c to
cfcd526
Compare
|
@Lunyachek someone on my team advised me that you can follow the merge-master-into-your-branch strategy, you just need to squash your commits prior to merge. Sorry I didn't know that, but now we both do! |
|
@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
This is a strange bug. It is related to a typo in the inline styles
style="margin:0 20 px 0"- there was a space between20andpxin the course about page template, which is the default for new courses. These styles did not work, so we could not see the bug. Then, in this pull request - #32890 - this typo was fixed, and now we are observing this bug (as shown in the screenshot below). We believe that this margin is completely unnecessary for the<img>tag, as the border and margin are set on the parent divteacher-imageBefore fix

After fix

Also RTL version
