Skip to content

feat: Adds disable_progress_graph attribute to the returned course_me… - #34324

Merged
cmltaWt0 merged 1 commit into
openedx:open-release/quince.masterfrom
raccoongang:fix-disable-progress-graph
Apr 8, 2024
Merged

feat: Adds disable_progress_graph attribute to the returned course_me…#34324
cmltaWt0 merged 1 commit into
openedx:open-release/quince.masterfrom
raccoongang:fix-disable-progress-graph

Conversation

@dyudyunov

Copy link
Copy Markdown
Contributor

Description

This is a backport from the master branch: #33308

Fix an issue when the Progress Graph toggle change in the studio has no effect on the Learning MFE.

Related backport for the Learning MFE: openedx/frontend-app-learning#1313

Please check the original PRs for more details.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 4, 2024
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @dyudyunov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Mar 4, 2024
@dyudyunov

dyudyunov commented Mar 5, 2024

Copy link
Copy Markdown
Contributor Author

Note: the related Learning MFE PR was merged openedx/frontend-app-learning#1313

@dyudyunov

Copy link
Copy Markdown
Contributor Author

@mphilbrick211 can someone review this?

@mphilbrick211

Copy link
Copy Markdown

@mphilbrick211 can someone review this?

Thanks for flagging, @dyudyunov - will look into getting a reviewer. Thanks for your patience!

@dyudyunov

Copy link
Copy Markdown
Contributor Author

hi @mphilbrick211

Sorry for flagging this one again
Just feel it is stuck 🥲

@mphilbrick211

Copy link
Copy Markdown

Hi @dyudyunov! I'm sorry for the delay. I'm trying to get a core contributor to look at this for you.

@cmltaWt0

cmltaWt0 commented Apr 7, 2024

Copy link
Copy Markdown
Contributor

@dyudyunov Please rebase the branch on the latest open-release/quince.master.
I'll test it and merge since the upstream PR is merged.

…tadata response

Currently, openedx/frontend-app-authoring#517 faces an issue when the
progress graph toggle is enabled/disabled but the settings are not respected, the disable_progress_graph
attribute will allow the frontend-app-learning repo to use this attribute to respect the settings authored
from frontend-app-course-authoring and ultimately fix openedx/frontend-app-authoring#517.
@dyudyunov
dyudyunov force-pushed the fix-disable-progress-graph branch from 7ac4adc to 2eb82ad Compare April 8, 2024 06:44
@cmltaWt0

cmltaWt0 commented Apr 8, 2024

Copy link
Copy Markdown
Contributor

@dyudyunov @mphilbrick211 Verified the fix on test env and going to merge this. 👍

@cmltaWt0
cmltaWt0 merged commit f3f160f into openedx:open-release/quince.master Apr 8, 2024
@openedx-webhooks

Copy link
Copy Markdown

@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@dyudyunov
dyudyunov deleted the fix-disable-progress-graph branch April 8, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants