feat: add share link button when hide from toc is enabled in sections - #34043
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @BryanttV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
35b6496 to
ffeb351
Compare
0d8ee55 to
a2c07c2
Compare
mariajgrimaldi
left a comment
mariajgrimaldi
left a comment
There was a problem hiding this comment.
This is working as expected! Thank you.
You have to address one last comment I left. Thanks again!
855a2db to
bb606e6
Compare
c64f1be to
ed0e707
Compare
967fde4 to
9a97386
Compare
fb794a4 to
3203030
Compare
There was a problem hiding this comment.
This would be better with isEnableHideFromTOCUI but I understand you will have to change enable_hide_from_toc_ui to is_enable_hide_from_toc_ui so is just a minor suggestion
There was a problem hiding this comment.
Yes, this field was included in the dependency PR. I'll leave the name as it is so as not to affect any other PR related to the functionality.
mariajgrimaldi
left a comment
mariajgrimaldi
left a comment
There was a problem hiding this comment.
This is working as it was described in the cover letter. Thank you! I'll approve this PR, although it's blocked by #33952
Also, remember to address @johnvente's comments! Thank you
|
Hi @johnvente, I addressed your comments, can you check again? thanks! |
Adds a new button in the child subsections of sections with Hide From TOC enabled. This button displays a new modal with two tabs. The first tab displays a button that allows you to copy the link of that subsection to the clipboard. The second tab displays a button that allows you to copy the embedded link of the same subsection to the clipboard. Ref: https://openedx.atlassian.net/wiki/spaces/OEPM/pages/3853975595/Feature+Enhancement+Proposal+Hide+Sections+from+course+outline
3203030 to
1742431
Compare
|
@BryanttV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
6 participants
Description
This PR adds a new button in the child subsections of sections with Hide From TOC enabled. This button displays a new modal with two tabs. The first tab displays a button that allows you to copy the link of that subsection to the clipboard. The second tab displays a button that allows you to copy the embedded link of the same subsection to the clipboard.
In this way, instructors will be able to pass the link to their students so that they can access the subsections that are hidden from the interface.
Supporting information
These changes are part of the effort made to implement Feature Enhancement Proposal: Hide Sections from Course Outline
Dependencies
Important
This PR needs the changes made from this PR, which includes the new section visibility option from Studio UI.
Testing instructions
edx-platformwithtutor mounts add <path/to/edx-platform>git checkout bav/add-share-link-buttongit rebase MJG/configurable-hide-from-tocand resolves conflicts by accepting both changes.FEATURES["ENABLE_HIDE_FROM_TOC_UI"] = Truetutor dev exec lms openedx-assets build --env=devto regenerate the assets.hft-share-link-demo.mp4
Deadline
This effort is part of the Spanish consortium project, so it'd be ideal to merge this before the end of the project.