Skip to content

feat: show message in visibility tab in subsections when hide from toc is enabled from ui - #33981

Merged
mariajgrimaldi merged 1 commit into
openedx:masterfrom
eduNEXT:bav/show-hft-message-in-visibility-tab-subsection
Mar 7, 2024
Merged

feat: show message in visibility tab in subsections when hide from toc is enabled from ui#33981
mariajgrimaldi merged 1 commit into
openedx:masterfrom
eduNEXT:bav/show-hft-message-in-visibility-tab-subsection

Conversation

@BryanttV

@BryanttV BryanttV commented Dec 29, 2023

Copy link
Copy Markdown
Contributor

Description

This PR shows a message in the visibility tab of the subsections when the Hide From TOC in UI is enabled. This is enabled with a Django setting flag used in this PR

Supporting information

These changes are part of the effort made to implement Feature Enhancement Proposal: Hide Sections from Course Outline

Screenshots

image

Dependencies

Important

This PR needs the changes made from this PR, which includes the new section visibility option from Studio UI.

Testing instructions

  1. In your environment add a mount of edx-platform with tutor mounts add <path/to/edx-platform>
  2. Move into this branch with git checkout bav/show-hft-message-in-visibility-tab-subsection
  3. Get the changes from this PR with git rebase MJG/configurable-hide-from-toc
  4. Run tutor dev exec lms openedx-assets build --env=dev for regenerate the assets.
  5. Create your course with sections and subsections.
  6. In the subsection settings (⚙️) go to the Visibility tab, you should not see any change.
  7. Now, add this setting in your environment: FEATURES["ENABLE_HIDE_FROM_TOC_UI"] = True
  8. Run tutor dev restart
  9. Go back to the subsection settings and see the new message.

Deadline

This effort is part of the Spanish consortium project, so it'd be ideal to merge this before the end of the project.

@openedx-webhooks

openedx-webhooks commented Dec 29, 2023

Copy link
Copy Markdown

Thanks for the pull request, @BryanttV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 29, 2023
Comment thread cms/static/sass/elements/_modal-window.scss Outdated
@BryanttV
BryanttV force-pushed the bav/show-hft-message-in-visibility-tab-subsection branch from 5019d36 to 5c475ad Compare December 29, 2023 22:20
@johnvente

Copy link
Copy Markdown

Hi @BryanttV! I've tested it and it's working as expected

Screen Shot 2024-01-02 at 1 55 02 PM

@mariajgrimaldi

Copy link
Copy Markdown
Member

This PR is an enhancement on #33952, so it depends on it for tests to pass. I'll open it for review either way since the implementation is ready.

@mariajgrimaldi
mariajgrimaldi marked this pull request as ready for review January 23, 2024 16:29
@BryanttV
BryanttV force-pushed the bav/show-hft-message-in-visibility-tab-subsection branch from 5c475ad to 7d79cc4 Compare February 12, 2024 20:19
@mariajgrimaldi
mariajgrimaldi self-requested a review February 12, 2024 22:49

@mariajgrimaldi mariajgrimaldi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Thank you. I won't merge this until we merge #33952, so I'll leave it as is in the meantime.

@johnvente johnvente left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This keeps working as expected, thanks!

@BryanttV
BryanttV force-pushed the bav/show-hft-message-in-visibility-tab-subsection branch 9 times, most recently from 0df7593 to 5299cd4 Compare February 14, 2024 20:55
@itsjeyd itsjeyd added the product review PR requires product review before merging label Feb 16, 2024
@itsjeyd itsjeyd added the product review complete PR has gone through product review label Feb 23, 2024
@BryanttV
BryanttV force-pushed the bav/show-hft-message-in-visibility-tab-subsection branch 3 times, most recently from efbcb01 to 4ee6157 Compare March 7, 2024 16:29
Comment thread cms/static/js/spec/views/pages/course_outline_spec.js Outdated
@BryanttV
BryanttV force-pushed the bav/show-hft-message-in-visibility-tab-subsection branch from b9473cb to 0e50012 Compare March 7, 2024 18:44
@BryanttV
BryanttV force-pushed the bav/show-hft-message-in-visibility-tab-subsection branch from 0e50012 to 000b65e Compare March 7, 2024 18:46

@mariajgrimaldi mariajgrimaldi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge once the tests pass. Thanks!

@mariajgrimaldi
mariajgrimaldi merged commit 8f88673 into openedx:master Mar 7, 2024
@openedx-webhooks

Copy link
Copy Markdown

@BryanttV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U product review complete PR has gone through product review product review PR requires product review before merging

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants