Skip to content

refactor: allow editing of ANONYMOUS_SURVEY_REPORT from env tokens - #33954

Merged
felipemontoya merged 1 commit into
openedx:masterfrom
eduNEXT:survey/refactor_anonymous_setting
Dec 19, 2023
Merged

refactor: allow editing of ANONYMOUS_SURVEY_REPORT from env tokens#33954
felipemontoya merged 1 commit into
openedx:masterfrom
eduNEXT:survey/refactor_anonymous_setting

Conversation

@Alec4r

@Alec4r Alec4r commented Dec 19, 2023

Copy link
Copy Markdown
Contributor

Description:

This PR adds the code that allows editing the value of the setting ANONYMOUS_SURVEY_REPORT from ENV_TOKENS.

This setting was added in previous PR https://github.com/openedx/edx-platform/pull/31431/files#diff-80e29d8214ecf239b743e73eaefccf89fbea558f97626cbbc817c5002d2b64fdR678

ISSUE:
openedx/axim-engineering#349

APPROVED DESIGN:
https://docs.google.com/document/d/1tm1O5BQsAwekphI5IN9pBn8behQDZigXePLGqCl5he8

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @Alec4r! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 19, 2023

@felipemontoya felipemontoya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix @Alec4r.

This is good to be merged.

@MaferMazu MaferMazu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@felipemontoya
felipemontoya merged commit ebcbe1c into openedx:master Dec 19, 2023
@openedx-webhooks

Copy link
Copy Markdown

@Alec4r 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants