Skip to content

Add endpoints to set user notification preference - #338

Closed
gwprice wants to merge 3 commits into
gprice/user-pref-servicefrom
gprice/notification-setting-endpoints
Closed

Add endpoints to set user notification preference#338
gwprice wants to merge 3 commits into
gprice/user-pref-servicefrom
gprice/notification-setting-endpoints

Conversation

@gwprice

@gwprice gwprice commented Jul 5, 2013

Copy link
Copy Markdown

No description provided.

@gwprice

gwprice commented Jul 5, 2013

Copy link
Copy Markdown
Author

@kevinchugh @jimabramson

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing doc string

The new API uses Django REST Framework. For now, it is designed specifically
to support the use cases required by the forum digest notifier (not yet built),
with a goal of making it more generally useful over time.
@gwprice

gwprice commented Jul 16, 2013

Copy link
Copy Markdown
Author

This is now stale; closing until the latest code is ready for review

@gwprice gwprice closed this Jul 16, 2013
@gwprice gwprice reopened this Jul 17, 2013
Greg Price added 2 commits July 17, 2013 17:13
Two endpoints are intended to be used by AJAX calls from the web UI with an
authenticated user. When enabled, the value of the preference is an encryption
of the username, to be used as a token for one-click unsubscribe links. The
third endpoint is the target of unsubscribe links, which displays a page with
an appropriate message to the user.
@jimabramson

Copy link
Copy Markdown

👍

@gwprice

gwprice commented Jul 19, 2013

Copy link
Copy Markdown
Author

@ormsbee Could you look at this one as well?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the require_GET() decorator instead?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. I just didn't know that existed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, there's also a similar decorator for @login_required

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't use login_required, because that returns a redirect if the requirement is not satisfied. Do we have a library somewhere for general-purpose view decorators?

@gwprice gwprice closed this Jul 22, 2013
martynjames pushed a commit that referenced this pull request Dec 3, 2014
…nges

Dcikatic/sol 20 filter changes - merging to get eyes on - still need to confirm correct test coverage
@marjev marjev mentioned this pull request May 6, 2015
xavierchan pushed a commit to xavierchan/edx-platform-1 that referenced this pull request Apr 3, 2019
Danyal-Faheem pushed a commit to Danyal-Faheem/edx-platform that referenced this pull request Jul 15, 2025
Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: Ali-Salman29 <Ali-Salman29@users.noreply.github.com>
kiram15 pushed a commit that referenced this pull request Jul 17, 2026
…ewStarted

feat: decouple enterprise from courseware view redirects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants