feat!: assume & remove BLOCKSTORE_USE_BLOCKSTORE_APP_API - #33765
Merged
kdmccormick merged 1 commit intoDec 6, 2023
Merged
Conversation
This was referenced Nov 21, 2023
kdmccormick
marked this pull request as ready for review
November 22, 2023 14:22
kdmccormick
force-pushed
the
kdmccormick/blockstore-service-depr-1
branch
from
November 27, 2023 14:37
a2d6c5c to
c5850d8
Compare
kdmccormick
force-pushed
the
kdmccormick/blockstore-service-depr-1
branch
from
December 6, 2023 14:56
c5850d8 to
424c0c9
Compare
kdmccormick
enabled auto-merge (squash)
December 6, 2023 14:58
connorhaugh
approved these changes
Dec 6, 2023
connorhaugh
left a comment
Contributor
There was a problem hiding this comment.
Super fast pass, but looks normal to me.
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, Blockstore was an independent micro-service, accessed via a REST API.
Then, we changed Blockstore so it could be installed as an in-process Django app.
To support both modes, there existed a blockstore_api wrapper library in edx-platform,
with toggles controlling whether the wrapper called out to the micro-service's REST API versus the
Django app's Python API. Now that the micro-service Blockstore implementation is deprecated,
though, this wrapper library and toggles are just unnecessary complexity.
As a first step towards cleanup, we:
marshalled them back into Python objects; and
In the future, we will remove the content libraries indexer,
clean up the remaining bits of blockstore_api, and flatten out all
the Blockstore-related test class hierarchies which are no longer ncessary.
BREAKING CHANGE:
or the Waffle switch blockstore.use_blockstore_app_api were enabled. That is, any running Blockstore
micro-service instance will be ignored, and the Blockstore package which is installed into edx-platform
will be used instead.
Ref: openedx-unsupported/blockstore#296