Skip to content

fix: decoration of see all children link in wiki pages - #33670

Merged
mariajgrimaldi merged 8 commits into
openedx:masterfrom
raccoongang:fix/wiki-see-all-children-style-master
Mar 27, 2024
Merged

fix: decoration of see all children link in wiki pages#33670
mariajgrimaldi merged 8 commits into
openedx:masterfrom
raccoongang:fix/wiki-see-all-children-style-master

Conversation

@ihor-romaniuk

Copy link
Copy Markdown
Contributor

Description

This pull request contains small recommendations for fixing the styling of the "See all children" link and replacing the decorative separator from the HTML markup with a style one.

Related Pull Requests

PR to the open-release/palm.master branch: #33668
PR to the open-release/quince.master branch: #33669

Screenshots/sandbox (optional):

Before After
image image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 7, 2023
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mariajgrimaldi

Copy link
Copy Markdown
Member

Hi @ihor-romaniuk! There are some testing failures, could you take a look? Thanks!

@ihor-romaniuk

ihor-romaniuk commented Jan 24, 2024

Copy link
Copy Markdown
Contributor Author

Hi @mariajgrimaldi! The Pull Request was updated and ready for review.

@mariajgrimaldi
mariajgrimaldi self-requested a review February 2, 2024 12:57
@mariajgrimaldi

Copy link
Copy Markdown
Member

Thanks @ihor-romaniuk! This looks better, but out of curiosity, why change it from markup to a style rule?

@cmltaWt0 cmltaWt0 added the product review PR requires product review before merging label Feb 8, 2024
@mariajgrimaldi mariajgrimaldi self-assigned this Feb 20, 2024
@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 21, 2024
@mphilbrick211

Copy link
Copy Markdown

Hi @mariajgrimaldi! Following up to see if you're still able to review this one?

@mphilbrick211

Copy link
Copy Markdown

Hi @mariajgrimaldi! Following up to see if you're still able to review this one?

Nevermind, @mariajgrimaldi - just realized this still needs product review.

@jmakowski1123

Copy link
Copy Markdown

This has product approval!

@mariajgrimaldi

Copy link
Copy Markdown
Member

I tested this locally and it's working as expected. I'll be merging this today, thanks!

@mariajgrimaldi
mariajgrimaldi merged commit f131110 into openedx:master Mar 27, 2024
@openedx-webhooks

Copy link
Copy Markdown

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@jmakowski1123 jmakowski1123 added product review complete PR has gone through product review and removed product review PR requires product review before merging labels Mar 28, 2024
@ihor-romaniuk
ihor-romaniuk deleted the fix/wiki-see-all-children-style-master branch April 18, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U product review complete PR has gone through product review waiting for eng review PR is ready for review. Review and merge it, or suggest changes.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants