Skip to content

[Quince Backport] feat: link LTI Provider launches to authenticated users - #33656

Merged
cmltaWt0 merged 1 commit into
openedx:open-release/quince.masterfrom
open-craft:tecoholic/quince-backport-lti-provider-user-auto-linking
Nov 21, 2023
Merged

[Quince Backport] feat: link LTI Provider launches to authenticated users#33656
cmltaWt0 merged 1 commit into
openedx:open-release/quince.masterfrom
open-craft:tecoholic/quince-backport-lti-provider-user-auto-linking

Conversation

@tecoholic

@tecoholic tecoholic commented Nov 6, 2023

Copy link
Copy Markdown
Contributor

Description

Quince backport of #33310

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@openedx-webhooks

openedx-webhooks commented Nov 6, 2023

Copy link
Copy Markdown

Thanks for the pull request, @tecoholic! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 6, 2023
@tecoholic tecoholic mentioned this pull request Nov 6, 2023
Closed
24 tasks
@tecoholic tecoholic changed the title feat: link LTI Provider launches to authenticated users [Quince Backport] feat: link LTI Provider launches to authenticated users Nov 6, 2023
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Nov 6, 2023
@tecoholic
tecoholic force-pushed the tecoholic/quince-backport-lti-provider-user-auto-linking branch from c19cc98 to 64a24c3 Compare November 9, 2023 17:22
@tecoholic @Agrendalath
feat: link LTI Provider launches to authenticated users
b8ff3ab 
With this change, the platform users who access content via LTI will be
automatically linked to their platform account instead of the new (anonymous)
one. The following conditions need to be met:
* The `LtiConsumer` should be configured to auto-link the users via email.
* The LTI Consumer should share the user's email using the
`lis_person_contact_email_primary` parameter in the LTI Launch POST data.

This also replaces the one-to-one relationship of the `User` and `LtiUser`
with one-to-many. This way, multiple `LtiUser` objects can refer to the same
`edx_user`. With the auto-linking, multiple LTI Consumers can create
independent `LtiUser` objects with the same `edx_user`.

Co-authored-by: Piotr Surowiec <piotr@surowiec.it>
(cherry picked from commit 5b2f012)
@Agrendalath
Agrendalath force-pushed the tecoholic/quince-backport-lti-provider-user-auto-linking branch from 4fc1e28 to b8ff3ab Compare November 13, 2023 18:43
Agrendalath
Agrendalath approved these changes Nov 13, 2023
View reviewed changes

@Agrendalath Agrendalath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: checked that the diff matches #33310
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation

@open-craft-grove

open-craft-grove commented Nov 15, 2023

Copy link
Copy Markdown

Sandbox update request received. Deployment will start soon.

@open-craft-grove

open-craft-grove commented Nov 15, 2023

Copy link
Copy Markdown

Sandbox deployment failed.

Check failure logs here https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5541071501.log

Please check the settings and requirements and retry deployment by updating the pull request or posting a /grove sandbox update comment.

@cmltaWt0

cmltaWt0 commented Nov 20, 2023

Copy link
Copy Markdown
Contributor

@tecoholic I've read through the original PR. It's an awesome work!

There is a great testing instruction in the original PR.
I think we have to merge it right now.

@mariajgrimaldi are you agree?

@tecoholic

tecoholic commented Nov 21, 2023

Copy link
Copy Markdown
Contributor Author

@cmltaWt0 Thank you. @mariajgrimaldi Kindly let me know if you need anything while testing.

@cmltaWt0
cmltaWt0 merged commit 6482e99 into openedx:open-release/quince.master Nov 21, 2023
@openedx-webhooks

openedx-webhooks commented Nov 21, 2023

Copy link
Copy Markdown

@tecoholic 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@cmltaWt0

cmltaWt0 commented Nov 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tested:

  • local images build
  • basic LTI Provider functionality

Not tested:

  • real Canvas integration

@open-craft-grove

open-craft-grove commented Nov 21, 2023

Copy link
Copy Markdown

Sandbox update request received. Deployment will start soon.

@tecoholic
tecoholic deleted the tecoholic/quince-backport-lti-provider-user-auto-linking branch November 22, 2023 05:54
@sarina sarina mentioned this pull request Mar 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Agrendalath Agrendalath Agrendalath approved these changes

Assignees

No one assigned

Labels

backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tecoholic @openedx-webhooks @open-craft-grove @cmltaWt0 @Agrendalath @mphilbrick211