Skip to content

fix: youtube race condition when GTM loads - #33650

Merged
pomegranited merged 1 commit into
openedx:open-release/quince.masterfrom
open-craft:viadanna/fix-gtm-race-condition-quince
Feb 5, 2024
Merged

fix: youtube race condition when GTM loads#33650
pomegranited merged 1 commit into
openedx:open-release/quince.masterfrom
open-craft:viadanna/fix-gtm-race-condition-quince

Conversation

@viadanna

@viadanna viadanna commented Nov 2, 2023

Copy link
Copy Markdown
Contributor

refer to #33649

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 2, 2023
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @viadanna! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Nov 2, 2023
@mariajgrimaldi

Copy link
Copy Markdown
Member

Hi there @viadanna! We usually backport PR(s) after their corresponding master PR is merged. So we'll review this contribution against quince.master once that happens. Thanks!

@mariajgrimaldi

Copy link
Copy Markdown
Member

Hi there @pomegranited! Let me know when you merge the masters' PR so we can merge this. Thank you folks!

@pomegranited

Copy link
Copy Markdown
Contributor

Hi @mariajgrimaldi , #33649 is merged.

@mariajgrimaldi

mariajgrimaldi commented Feb 5, 2024

Copy link
Copy Markdown
Member

Hi @pomegranited! Thanks for the ping. You can go ahead and merge this fix if you're confident with it. Can you also let the BTR channel know so they're aware too?

Thank you!

@pomegranited
pomegranited merged commit 8290087 into openedx:open-release/quince.master Feb 5, 2024
@pomegranited
pomegranited deleted the viadanna/fix-gtm-race-condition-quince branch February 5, 2024 23:55
@openedx-webhooks

Copy link
Copy Markdown

@viadanna 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants