Skip to content

Quince django42 upgrade - #33516

Merged
cmltaWt0 merged 6 commits into
open-release/quince.masterfrom
quince-django42-upgrade
Oct 30, 2023
Merged

Quince django42 upgrade#33516
cmltaWt0 merged 6 commits into
open-release/quince.masterfrom
quince-django42-upgrade

Conversation

@awais786

@awais786 awais786 commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

Final Django42 upgrade PR.

to and calling the url() method of the storage.
"""
matched, url = matchobj.groups()
matches = matchobj.groupdict()

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is from django32. They have made some changes in django4.2. So updated this code also. Otherwise it gives errors with collectstatic command.

This is related PR

@awais786 awais786 closed this Oct 17, 2023
@awais786 awais786 reopened this Oct 17, 2023

@cmltaWt0 cmltaWt0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the source branch via Tutor.
Basic functionality works. All users are logged out as expected due to DEFAULT_HASHING_ALGORITHM change.

@cmltaWt0
cmltaWt0 merged commit 2e55367 into open-release/quince.master Oct 30, 2023
@cmltaWt0
cmltaWt0 deleted the quince-django42-upgrade branch October 30, 2023 11:01
iamsobanjaved pushed a commit that referenced this pull request Dec 15, 2023
iamsobanjaved pushed a commit that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants