Skip to content

feat: receiver for verified exam event - #33390

Merged
alangsto merged 1 commit into
masterfrom
alangsto/verified_event_consumer
Oct 5, 2023
Merged

feat: receiver for verified exam event#33390
alangsto merged 1 commit into
masterfrom
alangsto/verified_event_consumer

Conversation

@alangsto

@alangsto alangsto commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

MST-2109

Description

This PR implements a new consumer for the EXAM_ATTEMPT_VERIFIED openedx event, which is sent via the event bus. The handler triggers an undo of a subsection grade override, if one exists.

@alangsto
alangsto changed the base branch from master to MST-1789-downstream-triggers October 2, 2023 14:18
@alangsto
alangsto changed the base branch from MST-1789-downstream-triggers to master October 3, 2023 16:30
@alangsto
alangsto force-pushed the alangsto/verified_event_consumer branch 9 times, most recently from df7196d to 0ec31dd Compare October 3, 2023 20:00

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment to function that is causing circular dependency issue when trying to do a top level import of any functions from api.py. This comment is taken from the PR that introduced this dependency.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this what was discussed in the huddle yesterday?

@alangsto
alangsto force-pushed the alangsto/verified_event_consumer branch from 0ec31dd to dc0effc Compare October 4, 2023 18:43

@varshamenon4 varshamenon4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Mocking is easy to read and understand.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this what was discussed in the huddle yesterday?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is also related to the convo yesterday about needing to do the import inline?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! This is what we chatted about in the huddle - because the python API for this service is meant to be used both externally and internally, we end up with some circular dependencies. To avoid that, we have to use an inline import here

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alangsto
alangsto force-pushed the alangsto/verified_event_consumer branch from dc0effc to 9574690 Compare October 5, 2023 16:50
@alangsto
alangsto merged commit db25297 into master Oct 5, 2023
@alangsto
alangsto deleted the alangsto/verified_event_consumer branch October 5, 2023 18:54
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants