feat: receiver for invalidate certificate - #33319
Conversation
9b7185c to
0715dd1
Compare
5682ef2 to
a414af3
Compare
b1e1b93 to
d7f2e6d
Compare
There was a problem hiding this comment.
this appears to just invalidate a cert and not do anything exam specific. I think we can leave the exam context out of here and just call it invalidate_certificate. It might be used for other purposes in the future.
There was a problem hiding this comment.
I think source might be a new parameter to this function. This is now called from multiple sources one is still certificate_service and the other is new (maybe exam_event?)
There was a problem hiding this comment.
Ah good point, I missed that. Will add that as a parameter to this function.
2bb6625 to
bff127d
Compare
varshamenon4
left a comment
varshamenon4
left a comment
There was a problem hiding this comment.
Looks great! I really like the descriptive comments, particularly the clarifications around the legacy vs. current exams backend. Just one question in the comments. :)
There was a problem hiding this comment.
Really descriptive and helpful comments throughout! Nice. :)
Already made the requested changes
- consumes event of exam attempt rejected - initial commit, need to make tests
- Still need to make this work - Need to make tests work too
- tests still need to be tweaked
bff127d to
b059701
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
4 participants
Description
Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.
Useful information to include:
"Developer", and "Operator".
changes.
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.