feat!: remove library_sourced block - #33257
Merged
kdmccormick merged 1 commit intoSep 15, 2023
Merged
Conversation
kdmccormick
force-pushed
the
kdmccormick/rm-library-sourced
branch
from
September 14, 2023 17:28
c5ab89c to
fbcd07c
Compare
kdmccormick
marked this pull request as ready for review
September 14, 2023 19:42
connorhaugh
approved these changes
Sep 14, 2023
connorhaugh
left a comment
connorhaugh
left a comment
Contributor
There was a problem hiding this comment.
Let's merge tomorrow morning for the sake of on-call, but looks good!
Rather than implementing V2-library and static-library-reference support in a new block, we will be enhancing the existing `LibraryContentBlock` in-place. Relevant ADR PR: openedx#33231
kdmccormick
force-pushed
the
kdmccormick/rm-library-sourced
branch
from
September 14, 2023 21:52
fbcd07c to
d81d774
Compare
This was referenced Sep 14, 2023
kdmccormick
changed the title
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, we planned to add support for V2 libraries and for static
(hand-selected) library block reference via new block type: library_sourced.
We have since decided that it would be better to add those capabilities
in-place to the existing library_content block. This will ease V1->V2
library migration and make adoption of the new features easier for current
library users. It will also avoid duplication of logic between two block types,
we we fear would be error-prone. For details, see this ADR:
#33231
So, we are removing the library_sourced block.
This block has existed in edx-platform for a few years now, but was not
enabled by default and never officially supported. It was only usable via the
experimental V2 content library feature. Operators who added library_sourced
blocks to their course will now see them render as
HiddenBlockinstances, i.e.:This should not impact other component types in such courses and should not
impact import/export.
What HiddenBlock looks like in Studio: