Add an API to interact with users and preferences - #331
Conversation
|
Hi, I know we've used tastypie for other services here at edX. Is it worth discussing whether we should keep a consistent REST framework? |
|
I've heard good things about Tastypie as well. I didn't realize we were already using it for REST apis at edX, but I think it's worth looking into for this one. |
|
We have a LMS API in the MITx instance - it's built using On Wed, Jul 3, 2013 at 2:41 PM, Calen Pennington
|
|
@cpennington I believe Vik's API's are implemented with Tastypie. |
|
@cpennington @chrisndodge: I also tried tastypie and ran into several bugs around related resources (trying to nest the user data in the user preference data). I submitted a pair of pull requests (one containing a pair of bugfixes and another containing a unit test demonstrating a third bug), but there hasn't been any action on them yet. The django-rest-framework project seems to be more active (at least over the last few months), and the code quality is superior. I do think that there is value in standardizing, but I also think that django-rest-framework is a superior option. |
|
@ichuang: Thanks for the pointer. I hadn't seen django-simple-rest before, but it looks a little too barebones. |
|
Cool. Glad to hear you've looked over both. |
|
What's the status of this pull request? I've rebased onto the latest master, so it's mergable again. Have you made @jtauber aware of the new libraries that this branch introduces? |
There was a problem hiding this comment.
Does this mean that if the settings key is misspelled or missing on a production site (say, Stanford's), we default to leaving this API open? If so, could you make the default behavior restrictive, and override that behavior to make it permissive where needed (dev.py, if a key is defined, etc.)?
There was a problem hiding this comment.
This was mostly for ease of development, but you are right that it should be more restrictive.
|
👍 |
|
The latest update was just pep8 and pylint violation cleanup and resolution of the CHANGELOG merge conflict |
The new API uses Django REST Framework. For now, it is designed specifically to support the use cases required by the forum digest notifier (not yet built), with a goal of making it more generally useful over time.
Add an API to interact with users and preferences
add back-compat code to customtag
Missing fix for static URL rewriting in discussion course
…x-layout-discussion Fix discussion layout openedx#331
…x-layout-discussion Fix discussion layout openedx#331 (cherry picked from commit 8962d1f)
…k-c2b4cf210f44bf883b1844d9c8349c8aac9d6bed Skip test that had a hardcoded date expectation MA-1038
The new API uses Django REST Framework. For now, it is designed specifically
to support the use cases required by the forum digest notifier (not yet built),
with a goal of making it more generally useful over time.
@jimabramson @kevinchugh