Skip to content

feat: use feature setting for beta tester notify - #32998

Merged
Agrendalath merged 1 commit into
openedx:masterfrom
open-craft:mohd-akram/batch-beta-notify
Aug 14, 2023
Merged

feat: use feature setting for beta tester notify#32998
Agrendalath merged 1 commit into
openedx:masterfrom
open-craft:mohd-akram/batch-beta-notify

Conversation

@mohd-akram

@mohd-akram mohd-akram commented Aug 14, 2023

Copy link
Copy Markdown
Contributor

Description

Use the BATCH_ENROLLMENT_NOTIFY_USERS_DEFAULT feature setting for the default value of the "notify users by email" checkbox under Batch Beta Tester Addition in a course's instructor dashboard (membership tab).

Testing instructions

  1. Set BATCH_ENROLLMENT_NOTIFY_USERS_DEFAULT to True
  2. Ensure the notify users checkbox is ticked by default
  3. Set BATCH_ENROLLMENT_NOTIFY_USERS_DEFAULT to False
  4. Ensure the notify users checkbox is unticked by default

Private-ref: BB-7751

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 14, 2023
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @mohd-akram! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Agrendalath Agrendalath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: checked that the behavior of the "Notify users email" checkbox in the "Batch Beta Tester Addition" section matches other checkboxes on this page
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

@Agrendalath
Agrendalath merged commit 43b2255 into openedx:master Aug 14, 2023
@Agrendalath
Agrendalath deleted the mohd-akram/batch-beta-notify branch August 14, 2023 16:25
@openedx-webhooks

Copy link
Copy Markdown

@mohd-akram 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants