Skip to content

fix: learner home serializer key error #32842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsprenkle merged 3 commits into from
Jul 26, 2023
Merged

fix: learner home serializer key error #32842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccbb436
test: reproduce
jansenk Jul 25, 2023
1925980
fix: allow missing authOrgId
jansenk Jul 25, 2023
48110dc
chore: lint
leangseu-edx Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lms/djangoapps/learner_home/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ class EnterpriseDashboardSerializer(serializers.Serializer):
label = serializers.CharField(source="name")
url = serializers.SerializerMethodField()
uuid = serializers.UUIDField()
authOrgId = serializers.CharField(source="auth_org_id")
authOrgId = serializers.CharField(source="auth_org_id", allow_null=True)
isLearnerPortalEnabled = serializers.BooleanField(source="enable_learner_portal")

def get_url(self, instance):
Expand Down
6 changes: 6 additions & 0 deletions lms/djangoapps/learner_home/test_serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1164,6 +1164,12 @@ def test_happy_path(self):
},
)

def test_no_auth_org_id(self):
""" Test for missing auth_org_id """
input_data = self.generate_test_enterprise_customer()
del input_data['auth_org_id']
self.assertIsNone(EnterpriseDashboardSerializer(input_data).data['authOrgId'])


class TestSocialMediaSettingsSiteSerializer(TestCase):
"""Tests for the SocialMediaSiteSettingsSerializer"""
Expand Down