Fix source editor for the case of no CodeMirror editor. - #3244
Merged
Conversation
Contributor
Author
|
@chrisndodge This will need to go into the release candidate. |
Contributor
There was a problem hiding this comment.
@cahrens Please use:
window.tinyMCE !== undefined && window.tinyMCE.activeEditor !== undefined
Your variant will throw an error if tinyMCE is not defined.
Contributor
There was a problem hiding this comment.
@cahrens You can read up on ReferenceError at http://javascriptweblog.wordpress.com/2010/08/16/understanding-undefined-and-preventing-referenceerrors/ or ask @singingwolfboy .
Contributor
|
I have checked it manually and it works well on local env 👍 |
In the HTML component, there is no longer a tabbed CodeMirror Editor. STUD-1516.
Author
|
@valera-rozuvan I addressed your feedback. |
Contributor
|
@cahrens 👍 Good to merge! |
cahrens
pushed a commit
that referenced
this pull request
Apr 8, 2014
Fix source editor for the case of no CodeMirror editor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the HTML component, there is no longer a tabbed CodeMirror Editor. STUD-1516.
There are no tests for this. I had previously written a smoke test for the high level source editor for LaTeX problems, but it has been disabled because the test did not pass reliably.
In problem-editor.feature:
Disabled 11/13/2013 after failing in master
The screenshot showed that the LaTeX editor had the text "hi",
but Selenium timed out waiting for the text to appear.
It also caused later tests to fail with "UnexpectedAlertPresent"
This feature will work in Firefox only when Firefox is the active window
IE will not interact with the high level source in sauce labs
#@skip_internetexplorer
#Scenario: High Level source is persisted for LaTeX problem (bug STUD-280)
Given I have created a LaTeX Problem
When I edit and compile the High Level Source
Then my change to the High Level Source is persisted
And when I view the High Level Source I see my changes