Skip to content

Platform requirements reorg - #3224

Closed
e0d wants to merge 2 commits into
masterfrom
e0d/reqirements
Closed

Platform requirements reorg#3224
e0d wants to merge 2 commits into
masterfrom
e0d/reqirements

Conversation

@e0d

@e0d e0d commented Apr 4, 2014

Copy link
Copy Markdown
Contributor

This work is motivated by general code hygiene concerns and moving toward building all ansible managed, and maybe all, environments using pip wheel packages.

This has been tested with the full stack, cf., http://jenkins.edx.org:8080/job/ansible-provision/164/

  • removes requirements file includes entirely.
  • moves leaked github requirements in base.txt into github.txt, these have not revision, which is a problem.
  • adds additional files that were included into pavers pre-reqs
  • removes distribute entirely
  • experimentally makes local installs use wheels, may need to roll this back, but works in ansible land, would be super if we could pull these out of platform entirely.

@jarv @feanil @hkim823 @singingwolfboy @cpennington Please let me know your thoughts, there will be a related configuration PR to follow.

Comment thread requirements/edx/github.txt Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By this you mean, the has for static files, and not the req missing versions entirely, right?

Those were migrated from base.txt.

@feanil

feanil commented Apr 8, 2014

Copy link
Copy Markdown
Contributor

looks good to me.

Comment thread requirements/edx/post.txt Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change doesn't appear to belong in this PR, does it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's related to wheels, there seems to have been a packaging but in 1.2.4 that probably accounts for our issues with it and distribute, but also prevented it from wheeling up cleanly.

@jarv

jarv commented Apr 8, 2014

Copy link
Copy Markdown
Contributor

other than mysql-python, 👍

@singingwolfboy

Copy link
Copy Markdown
Contributor

Looks like this PR needs a rebase.

@singingwolfboy

Copy link
Copy Markdown
Contributor

@e0d Can this be merged?

e0d added 2 commits July 31, 2014 15:50
rolling back local changes.

bad cnp
removing extra space

trailing comma

reverting mysql upgrade

adding -e for ora2

making Xblock editable source

making splash editable source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants