Repository navigation
feat: tpa automatic logout #32193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tpa automatic logout #32193
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1215,6 +1215,19 @@ | |
| TPA_PROVIDER_BURST_THROTTLE = '10/min' | ||
| TPA_PROVIDER_SUSTAINED_THROTTLE = '50/hr' | ||
|
|
||
| # .. toggle_name: TPA_AUTOMATIC_LOGOUT_ENABLED | ||
| # .. toggle_implementation: DjangoSetting | ||
| # .. toggle_default: False | ||
| # .. toggle_description: Redirect the user to the TPA logout URL if this flag is enabled, the | ||
| # TPA logout URL is configured, and the user logs in through TPA. | ||
| # .. toggle_use_cases: open_edx | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nit] I believe this would generally be considered an
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for linking the docs. |
||
| # .. toggle_warning: Enabling this toggle skips rendering logout.html, which is used to log the user out | ||
| # from the different IDAs. To ensure the user is logged out of all the IDAs be sure to redirect | ||
| # back to <LMS>/logout after logging out of the TPA. | ||
| # .. toggle_creation_date: 2023-05-07 | ||
| # .. toggle_tickets: https://github.com/openedx/edx-platform/pull/32193 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed this. |
||
| TPA_AUTOMATIC_LOGOUT_ENABLED = False | ||
|
|
||
| ################################## TEMPLATE CONFIGURATION ##################################### | ||
| # Mako templating | ||
| import tempfile # pylint: disable=wrong-import-position,wrong-import-order | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should only have this defined on the LMS side -- the CMS side just redirects to LMS for logout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timmc-edx You are right, I added this in the CMS side only because some CMS test cases were failing. In hindsight, that was the incorrect way to go about it, I have now handled it differently and removed it from the CMS side.