Skip to content

This should enable logging of codejail on prod - #3212

Merged
davestgermain merged 1 commit into
masterfrom
dcs/log-codejail
Apr 7, 2014
Merged

This should enable logging of codejail on prod#3212
davestgermain merged 1 commit into
masterfrom
dcs/log-codejail

Conversation

@davestgermain

Copy link
Copy Markdown
Contributor

I wasn't sure exactly where to put this, but aws.py seems like the most expedient place.

@nedbat @e0d

@e0d

e0d commented Apr 7, 2014

Copy link
Copy Markdown
Contributor

This only additional logging we expect to be activated by this is:

https://github.com/edx/codejail/blob/e3d98f9455c2fb5e39c42fa024e378d6e84b3215/codejail/jail_code.py#L212

It's a quibble, but that feels more like INFO to me.

@davestgermain

Copy link
Copy Markdown
Contributor Author

You're probably right, but I figured that this change would be approved quicker because otherwise I'd have to make two PR's (one for codejail, and one for edx-platform, to reference the updated version)... It really doesn't matter to me whether it's debug or info.

@e0d

e0d commented Apr 7, 2014

Copy link
Copy Markdown
Contributor

I'm happy to get this in so we can close out the related issues. 👍 @jarv Any issues with this change?

davestgermain pushed a commit that referenced this pull request Apr 7, 2014
This should enable logging of codejail on prod
@davestgermain
davestgermain merged commit 25f722d into master Apr 7, 2014
@davestgermain
davestgermain deleted the dcs/log-codejail branch April 7, 2014 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants