Skip to content

feat: put sending xblock events over bus behind feature flag - #31813

Merged
dianakhuang merged 1 commit into
openedx:masterfrom
open-craft:navin/xblock-events-feature-flag
Feb 22, 2023
Merged

feat: put sending xblock events over bus behind feature flag#31813
dianakhuang merged 1 commit into
openedx:masterfrom
open-craft:navin/xblock-events-feature-flag

Conversation

@navinkarkera

Copy link
Copy Markdown
Contributor

As per discussion in #31350 (comment), this MR adds a feature flag to enable/disable sending xblock related openedx-events to external bus.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 22, 2023
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@rgraber rgraber left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call this a feat: rather than refactor: but that's a minor point.

Comment thread cms/djangoapps/contentstore/signals/handlers.py Outdated
@navinkarkera
navinkarkera force-pushed the navin/xblock-events-feature-flag branch from 95f4e28 to 6373cb4 Compare February 22, 2023 13:43
Comment thread cms/envs/devstack.py
@navinkarkera navinkarkera changed the title refactor: put sending xblock events over bus behind feature flag feat: put sending xblock events over bus behind feature flag Feb 22, 2023

@rgraber rgraber left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariajgrimaldi mariajgrimaldi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dianakhuang @rgraber @rgraber: this looks great! merge when convenient :)

@dianakhuang
dianakhuang merged commit 5ed5cc5 into openedx:master Feb 22, 2023
@openedx-webhooks

Copy link
Copy Markdown

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

1 similar comment
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@pdpinch

pdpinch commented Feb 22, 2023

Copy link
Copy Markdown
Contributor

Hi. I help write the release notes for open edX, and I have a couple of questions:

  • Will the event bus be supported in the next release, Palm?
  • As an open edX operator, where would I find out more information about how to turn on the event bus?
  • Is this the only required flag?

@navinkarkera

navinkarkera commented Feb 23, 2023

Copy link
Copy Markdown
Contributor Author

@pdpinch

Will the event bus be supported in the next release, Palm?

I think it is already supported, so it should be the same in next release. cc @mariajgrimaldi

As an open edX operator, where would I find out more information about how to turn on the event bus?

Below links should be helpful:

Is this the only required flag?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants