Skip to content

Emit datadog events for all course enrollments, not just those outside of verified courses - #3158

Merged
cpennington merged 1 commit into
openedx:masterfrom
cpennington:enrollment-metrics
Apr 1, 2014
Merged

Emit datadog events for all course enrollments, not just those outside of verified courses#3158
cpennington merged 1 commit into
openedx:masterfrom
cpennington:enrollment-metrics

Conversation

@cpennington

Copy link
Copy Markdown
Contributor

No description provided.

@cpennington

Copy link
Copy Markdown
Contributor Author

@dianakhuang @sarina @flowerhack: Review?

Comment thread common/djangoapps/student/models.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we doing this parsing twice?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Good question.

@dianakhuang

Copy link
Copy Markdown
Contributor

Once tests pass, this looks good to me 🚢

@flowerhack

Copy link
Copy Markdown
Contributor

🎋 🍰

cpennington added a commit that referenced this pull request Apr 1, 2014
Emit datadog events for all course enrollments, not just those outside of verified courses
@cpennington
cpennington merged commit 2689967 into openedx:master Apr 1, 2014
@cpennington
cpennington deleted the enrollment-metrics branch April 1, 2014 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants