Fixes LMS-2474 by ensuring that readElts reads always reads an element - #3134
Merged
Conversation
Contributor
|
@davestgermain , running the new test with the old code in capa/display.coffee doesn't yield a test failure. It should... |
Contributor
Author
|
@adampalay oh, duh... I wasn't testing the right thing. OK, I figured out how to load the SR object in the tests, and verified that the old code failed the test. |
Contributor
|
this needs a rebase too |
Contributor
|
👍 , but it should get another review. |
Contributor
There was a problem hiding this comment.
@davestgermain For consistency's sake (see how spyOn is used throughout this file), please update to:
spyOn SR, 'readElts'
spyOn SR, 'readText'
Contributor
|
@davestgermain Code looks good. Waiting to see what Jenkins says. |
Contributor
|
@davestgermain 👍 Good to merge! |
davestgermain
pushed a commit
that referenced
this pull request
Apr 1, 2014
Fixes LMS-2474 by ensuring that readElts reads always reads an element
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@adampalay