Skip to content

Addition of not responded posts filter in fetch threads lists API. #31275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mehaknasir merged 2 commits into from
Nov 11, 2022
Merged

Addition of not responded posts filter in fetch threads lists API. #31275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1dba40
feat: added not responded filter for fetch thread list api
mehaknasir Nov 9, 2022
64460d9
Merge branch 'master' into inf-524
mehaknasir Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lms/djangoapps/discussion/rest_api/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,7 +873,7 @@ def get_thread_list(
}

if view:
if view in ["unread", "unanswered"]:
if view in ["unread", "unanswered", "unresponded"]:
query_params[view] = "true"
else:
ValidationError({
Expand Down
2 changes: 1 addition & 1 deletion lms/djangoapps/discussion/rest_api/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class ThreadListGetForm(_PaginationForm):
count_flagged = ExtendedNullBooleanField(required=False)
flagged = ExtendedNullBooleanField(required=False)
view = ChoiceField(
choices=[(choice, choice) for choice in ["unread", "unanswered"]],
choices=[(choice, choice) for choice in ["unread", "unanswered", "unresponded"]],
required=False,
)
order_by = ChoiceField(
Expand Down
2 changes: 1 addition & 1 deletion lms/djangoapps/discussion/rest_api/tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,7 +955,7 @@ def test_basic(self):
"per_page": ["10"],
})

@ddt.data("unread", "unanswered")
@ddt.data("unread", "unanswered", "unresponded")
def test_view_query(self, query):
threads = [make_minimal_cs_thread()]
self.register_get_user_response(self.user)
Expand Down
2 changes: 1 addition & 1 deletion lms/djangoapps/discussion/rest_api/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ class ThreadViewSet(DeveloperErrorViewMixin, ViewSet):

* view: "unread" for threads the requesting user has not read, or
"unanswered" for question threads with no marked answer. Only one
can be selected.
can be selected, or unresponded for discussion type posts with no response

* requested_fields: (list) Indicates which additional fields to return
for each thread. (supports 'profile_image')
Expand Down