Reduce false cache misses when evaluating prerequisites - #3097
Merged
Conversation
Contributor
|
Makes sense. Please update the docstring for |
Contributor
|
👍 |
davestgermain
pushed a commit
that referenced
this pull request
Mar 28, 2014
Reduce false cache misses when evaluating prerequisites
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous function was building a hash of the list of every single file in the site-packages directory, effectively making every execution a cache-miss and slowing down server startup. I think it's reasonable to hash the contents of the requirements files and just the modification times of the modules under site-packages (even that is probably not necessary)
@singingwolfboy @wedaly @cpennington