Add metrics around old ORA requests - #3091
Conversation
|
@dianakhuang @sarina @flowerhack: Review? |
|
Overall looks good to me and squares with how I understand old ORA to work. Would be worth having @dianakhuang take a pass too. |
|
It looks like there's a bunch of errors coming from the ORA tests. Definitely think that should be something to take a look at. It might just be a bunch of badly mocked interfaces, but we should fix those on top of the JSON handling stuff. |
|
@sarina @dianakhuang: Fixed the tests |
|
looks like 2 of the failing bok choy tests have to do with ORA still (https://jenkins.testeng.edx.org/job/edx-all-tests-auto-pr/7661/SHARD=1,TEST_SUITE=bok-choy/). The other failures might be flaky - seems pretty bad that we have so many flaky tests |
|
Oh, indeed. I'll try the bok_choy tests locally, and see what's what. |
|
This is now only failing the flaky xblock bok-choy test. @sarina, @dianakhuang, @flowerhack: Final review? |
|
Echoing @sarina 's request for a docstring for |
…s returning strings
…ingService get and post methods
|
added docstrings. |
|
👍 |
|
✨ 👍 |
Add metrics around old ORA requests
No description provided.