Skip to content

Add metrics around old ORA requests - #3091

Merged
cpennington merged 8 commits into
openedx:masterfrom
cpennington:ora-metrics
Apr 1, 2014
Merged

Add metrics around old ORA requests#3091
cpennington merged 8 commits into
openedx:masterfrom
cpennington:ora-metrics

Conversation

@cpennington

Copy link
Copy Markdown
Contributor

No description provided.

@cpennington

Copy link
Copy Markdown
Contributor Author

@dianakhuang @sarina @flowerhack: Review?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstrings here

@sarina

sarina commented Mar 27, 2014

Copy link
Copy Markdown
Contributor

Overall looks good to me and squares with how I understand old ORA to work. Would be worth having @dianakhuang take a pass too.

@dianakhuang

Copy link
Copy Markdown
Contributor

It looks like there's a bunch of errors coming from the ORA tests. Definitely think that should be something to take a look at. It might just be a bunch of badly mocked interfaces, but we should fix those on top of the JSON handling stuff.

@cpennington

Copy link
Copy Markdown
Contributor Author

@sarina @dianakhuang: Fixed the tests

@sarina

sarina commented Mar 28, 2014

Copy link
Copy Markdown
Contributor

looks like 2 of the failing bok choy tests have to do with ORA still (https://jenkins.testeng.edx.org/job/edx-all-tests-auto-pr/7661/SHARD=1,TEST_SUITE=bok-choy/). The other failures might be flaky - seems pretty bad that we have so many flaky tests

@cpennington

Copy link
Copy Markdown
Contributor Author

Oh, indeed. I'll try the bok_choy tests locally, and see what's what.

@cpennington

Copy link
Copy Markdown
Contributor Author

This is now only failing the flaky xblock bok-choy test. @sarina, @dianakhuang, @flowerhack: Final review?

@dianakhuang

Copy link
Copy Markdown
Contributor

Echoing @sarina 's request for a docstring for _record_result but otherwise, it looks good.

@cpennington

Copy link
Copy Markdown
Contributor Author

added docstrings.

@dianakhuang

Copy link
Copy Markdown
Contributor

👍

@sarina

sarina commented Apr 1, 2014

Copy link
Copy Markdown
Contributor

✨ 👍

cpennington added a commit that referenced this pull request Apr 1, 2014
Add metrics around old ORA requests
@cpennington
cpennington merged commit 1bd0bcb into openedx:master Apr 1, 2014
@cpennington
cpennington deleted the ora-metrics branch April 1, 2014 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants