fix typo in data download tab (LMS-2441) - #3041
Merged
Merged
Conversation
Contributor
|
/me facepalm How did test not catch it? 👍 |
Contributor
Author
|
we didn't have an acceptance test for that button, remember? |
Contributor
|
ah ah ah yeah right, acceptance test for downloading a file is tricky/impossible and not recommended. |
Contributor
|
I really did think it had worked for me locally. Weird. |
Contributor
Author
|
@sarina so the crazy thing is that it would work locally because you're presumably testing on "small" courses. The two buttons have the same |
Contributor
|
@adampalay 😠 😱 😲 😡 |
adampalay
added a commit
that referenced
this pull request
Mar 24, 2014
fix typo in data download tab (LMS-2441)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sarina , this caused https://edx-wiki.atlassian.net/browse/LMS-2441
@symbolist