Skip to content

feat: email linking for SSO - #30258

Merged
mubbsharanwar merged 1 commit into
masterfrom
mubbshar/VAN-331
Apr 26, 2022
Merged

feat: email linking for SSO#30258
mubbsharanwar merged 1 commit into
masterfrom
mubbshar/VAN-331

Conversation

@mubbsharanwar

@mubbsharanwar mubbsharanwar commented Apr 15, 2022

Copy link
Copy Markdown
Contributor

Make email linking for SSO as default behavior.

Steps to test locally:
Enable social-auth locally for SSO.
Create account using registration form flow.
SSO through same email which user used for first time registration.
User will redirect to LMS after authentication.
User account will be linked to existing account.

VAN-331

@mubbsharanwar
mubbsharanwar force-pushed the mubbshar/VAN-331 branch 9 times, most recently from 5bae879 to 0cef37d Compare April 19, 2022 16:27

@waheedahmed waheedahmed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make email linking for SSO as default behavior.
VAN-331
@mubbsharanwar

Copy link
Copy Markdown
Contributor Author

@waheedahmed Oh yes we can remove this override setting because it's enabled by default now. I updated PR plz verify changes and let me know if there is any further change required.

@pdpinch

pdpinch commented Apr 20, 2022

Copy link
Copy Markdown
Contributor

It doesn't look like the JIRA issue https://openedx.atlassian.net/browse/VAN-331 is open to the public. Can you add some more details to the PR description and/or the commit message about what this feature does?

@mubbsharanwar

mubbsharanwar commented Apr 21, 2022

Copy link
Copy Markdown
Contributor Author

Hi @pdpinch,
Currently, in the edX platform, if you try to login with an SSO account using the login form, a username is generated for you based on the email that is used with the SSO provider.

If the username already exists in the platform, you run into a small conflict which sends you back to the login form and requests to sign in using password.
It basically requests that you link your edX account and your SSO account.

In this PR we just try to reducing the user hurdle and make it default behavior to link your edX account and your SSO account by removing ENABLE_REQUIRE_THIRD_PARTY_AUTH flag from pipeline because a pipeline was added to associate the user by email when the ENABLE_REQUIRE_THIRD_PARTY_AUTH flag enable and the social auth provider is an Oauth2 provider. But by default ENABLE_REQUIRE_THIRD_PARTY_AUTH was disabled and we removed this flag from pipeline to link edX account and your SSO account.

@waheedahmed

Copy link
Copy Markdown
Contributor

Hi @pdpinch, this functionally was added by the community in this PR https://github.com/edx/edx-platform/pull/25935 but behind the ENABLE_REQUIRE_THIRD_PARTY_AUTH flag and we have enabled it by default for all.

@mubbsharanwar
mubbsharanwar merged commit 0ed58f3 into master Apr 26, 2022
@mubbsharanwar
mubbsharanwar deleted the mubbshar/VAN-331 branch April 26, 2022 07:13
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

jawad-khan pushed a commit that referenced this pull request Jun 14, 2022
Make email linking for SSO as default behavior.
VAN-331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants