Show a confirmation on asset delete. Fixes STUD-375. - #302
Conversation
|
The code itself looks fine. But I'm worried about how it looks when you delete multiple assets. It's not useful after the first deletion, and confusing if you cancel a deletion. |
|
Talked to Brian about this -- the confirmation shows up at the bottom of the page now, and disappears after two seconds. |
|
I haven't tried the branch, but the code looks good. What's the build failure from? Violations? |
|
I like this much, much better. We should consider changing Advanced Settings as well (and Course Settings?). I ran the Lettuce test and it passed. I was worried about timing since the delete notification now dismisses, but it looks like the CSS is still present once it has been shown, even if enough time has passed for it to auto-hide? Can't view Jenkins failures from home. |
|
The tests (unit tests and Lettuce) all run locally for me -- I can't see Jenkins errors as I don't have a kerberos login. It was probably a pylint error (fixed in the latest commit). |
|
It was actually test failures. But they would appear to be completely unrelated, so let's see what happens when your last commit runs. |
|
👍 |
Show a confirmation on asset delete. Fixes STUD-375.
fix courseware css file so it imports the right files in the right order
…nsitional_ids mattdrayer/api-migrate_transitional_ids: Cleaned up two additional table...
* Commits: Remove Travis-CI integration
3 participants
No description provided.