Standardize types used for logging events from the instructor dashboard - #293
Merged
Conversation
Contributor
There was a problem hiding this comment.
Could you shorten the line length of this?
|
Looks good modulo a) line length, b) making sure it gets merged with Miles's work properly. |
Contributor
|
Yeah, I agree with Victor that this is fine once you figure out why tests are failing on this branch. |
rlucioni
added a commit
that referenced
this pull request
Jun 28, 2013
Standardize types used for logging events from the instructor dashboard
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Adding script that restarts django when content in the data directories changes.
e-kolpakov
referenced
this pull request
in open-craft/openedx-platform
Nov 10, 2014
…rogress moved cmc from api_manager to progress
yokose-ks
added a commit
to nttks/edx-platform
that referenced
this pull request
Oct 6, 2015
Merge pull request openedx#279 from yokose-ks/develop/cypress/modify-file-up…
This was referenced Oct 4, 2021
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
…nt (openedx#293) Add a new lock paywall component to be shown as part of the Purchase squad's Value Prop Optimizely experiment.
kiram15
pushed a commit
that referenced
this pull request
Jul 17, 2026
…9ed0 feat: Upgrade Python dependency edx-enterprise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information previously sent through the
event_typestring is now sent in appropriately named fields within theeventdictionary, which is what it was designed to be used for. These changes will be cataloged/documented in my LMS Event Inventory wiki page, and will merge with Miles' refactor. @dianakhuang and @shnayder, we spoke about this earlier - could you please review?