Skip to content

(WIP) initial experiment for enabling accordion control for lms navigation. - #2854

Closed
marcotuts wants to merge 1 commit into
masterfrom
marco/lms-navigation-toggle
Closed

(WIP) initial experiment for enabling accordion control for lms navigation.#2854
marcotuts wants to merge 1 commit into
masterfrom
marco/lms-navigation-toggle

Conversation

@marcotuts

Copy link
Copy Markdown
Contributor

Initial changes to enabling the navigation accordion control, presuming no configuration or settings necessary to merge this into the platform for now.

1.) IN PROGRESS - Expose collapsible navigation control
2.) Add in breadcrumb navigation above Unit page sequential allowing for clearer presence/location especially if user has navigation collapsed.
3.) When user clicks subsection in navigation sidebar, default (eventually) to collapsing sidebar once breadcrumb is in place.
4.) Visual cleanup to existing sequential bar and iconography used for accordion controls.

https://www.dropbox.com/s/oihhfxcan6qwe3e/Screenshot%202014-03-07%2005.17.15.png

via Hackathon 6. https://github.com/edx/edx-platform/wiki/Hackathon-Six%3A-New-Digs

@marcotuts

Copy link
Copy Markdown
Contributor Author

Still To Do:

  1. a11y - text in sr span,
  2. transition --> animation/text/review,
  3. font-awesome icon double caret left.
  4. show text on hover

@singingwolfboy singingwolfboy changed the title (DO NOT MERGE) initial experiment for enabling accordion control for lms navigation. (WIP) initial experiment for enabling accordion control for lms navigation. Apr 25, 2014
@singingwolfboy

Copy link
Copy Markdown
Contributor

@marcotuts What do you want to do about this pull request? It's not helpful if it's just sitting here without any forward progress.

@marcotuts

Copy link
Copy Markdown
Contributor Author

@shnayder - I'm going to go ahead and close this pull request for now, as it was mostly meant as a proof of concept and has been open/inactive for 2 months now. We can add this to the backlog, though if possible my recommendation would be to land this other pull request before the addition of this control. https://github.com/edx/edx-platform/pull/3096

thanks @singingwolfboy for the nudge on this. Stale PRs are stale PRs.

@marcotuts marcotuts closed this Apr 25, 2014
@marcotuts
marcotuts deleted the marco/lms-navigation-toggle branch August 6, 2014 02:50
@marcotuts
marcotuts restored the marco/lms-navigation-toggle branch August 6, 2014 02:50
@benpatterson
benpatterson deleted the marco/lms-navigation-toggle branch January 21, 2015 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants