(WIP) initial experiment for enabling accordion control for lms navigation. - #2854
Closed
marcotuts wants to merge 1 commit into
Closed
(WIP) initial experiment for enabling accordion control for lms navigation.#2854marcotuts wants to merge 1 commit into
marcotuts wants to merge 1 commit into
Conversation
Contributor
Author
|
Still To Do:
|
Contributor
|
@marcotuts What do you want to do about this pull request? It's not helpful if it's just sitting here without any forward progress. |
Contributor
Author
|
@shnayder - I'm going to go ahead and close this pull request for now, as it was mostly meant as a proof of concept and has been open/inactive for 2 months now. We can add this to the backlog, though if possible my recommendation would be to land this other pull request before the addition of this control. https://github.com/edx/edx-platform/pull/3096 thanks @singingwolfboy for the nudge on this. Stale PRs are stale PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial changes to enabling the navigation accordion control, presuming no configuration or settings necessary to merge this into the platform for now.
1.) IN PROGRESS - Expose collapsible navigation control
2.) Add in breadcrumb navigation above Unit page sequential allowing for clearer presence/location especially if user has navigation collapsed.
3.) When user clicks subsection in navigation sidebar, default (eventually) to collapsing sidebar once breadcrumb is in place.
4.) Visual cleanup to existing sequential bar and iconography used for accordion controls.
https://www.dropbox.com/s/oihhfxcan6qwe3e/Screenshot%202014-03-07%2005.17.15.png
via Hackathon 6. https://github.com/edx/edx-platform/wiki/Hackathon-Six%3A-New-Digs