Skip to content

fix: Passwored reset page throwing page not found error - #28204

Merged
davidjoy merged 1 commit into
openedx:open-release/lilac.masterfrom
open-craft:farhaan/bb-4413-port-password-change
Jul 23, 2021
Merged

fix: Passwored reset page throwing page not found error#28204
davidjoy merged 1 commit into
openedx:open-release/lilac.masterfrom
open-craft:farhaan/bb-4413-port-password-change

Conversation

@farhaanbukhsh

@farhaanbukhsh farhaanbukhsh commented Jul 16, 2021

Copy link
Copy Markdown
Member

The password-reset page throws page not found error on refresh. This started happening in koa.

JIRA tickets: BB-4413

Discussions: Link to any public dicussions about this PR or the design/architecture. Otherwise omit this.

Dependencies: None

Screenshots:

Juniper Behaviour

juniper-password-reset

Koa Behaviour
koa-password-reset

Sandbox URL: TBD - sandbox is being provisioned.

Merge deadline: "None" if there's no rush, "ASAP" if it's critical, or provide a specific date if there is one.

Testing instructions:

  1. Use master devstack
  2. Go to the sign-in page click on need more help and then password-reset page
  3. Hit refresh you will get a page not found error
  4. Pull in this branch code, do a make lms-static and make lms-restart
  5. Repeat the above steps the error should not change.

Author notes and concerns:

  1. Error happened because of change in URL which was not required
  2. This is back-port from https://github.com/edx/edx-platform/pull/27982

Reviewers

Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @farhaanbukhsh! I've created OSPR-5917 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Jul 16, 2021
@natabene

Copy link
Copy Markdown
Contributor

@farhaanbukhsh Thank you for your contribution. Please let me know once it is ready for our review.

@farhaanbukhsh

Copy link
Copy Markdown
Member Author

@natabene this is ready , it is a backport of https://github.com/edx/edx-platform/pull/27982#issuecomment-885015185

@openedx-webhooks

Copy link
Copy Markdown

@farhaanbukhsh 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

dmitry-viskov pushed a commit to weaveeducation/edx-platform that referenced this pull request Sep 22, 2021
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants