fix: hide unavailable sequence title in course breadcrumbs [BB-4305] - #28028
Conversation
When a sequence title was unavailable for a user (e.g. before starting a timed exam), the `None` value was displayed in course breadcrumbs. This hides it in such cases and ensures that a trailing breadcrumb separator is not displayed.
|
Thanks for the pull request, @Agrendalath! I've created OSPR-5882 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
Your PR has finished running tests. There were no failures. |
shimulch
left a comment
There was a problem hiding this comment.
@Agrendalath Thanks for fixing this. LGTM 👍
- I tested this on my local devstack. Reproduced the issue and verified that this PR resolves it.
- I read through the code
- [N/A] I checked for accessibility issues
- Includes documentation
- [N/A] I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
|
@natabene, this is ready for your review. |
|
@Agrendalath Thank you for your contribution. |
|
@Agrendalath 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Description
When a sequence title is unavailable for a user (e.g. before starting a timed exam), the
Nonevalue is displayed in course breadcrumbs. This hides it in such cases and ensures that a trailing breadcrumb separator is not displayed.This replaces #27900.
Jira
OSPR-5882
Sandbox
https://pr28028.sandbox.opencraft.hosting/
Note: the course navigation does not work properly in the legacy frontend, but it's an issue related to the
masterbranch. Settingcourseware.use_legacy_frontenddidn't resolve this, so we've included a direct link to the exam in testing instructions.Testing instructions
audit.Manual testing instructions
envs/private.py:paver compile_sass.honor(or another non-staff user).Noneis no longer visible.Deadline
None.
Reviewers
Settings