[BACKPORT] fix: Hide enterprise/login button if enterprise integration disabled. - #27834
Merged
Merged
Conversation
…openedx#27130) * fix: Hide enterprise/login button if enterprise integration disabled. [BTR-52](https://openedx.atlassian.net/browse/BTR-52) Fix an issue with existing button for enterprise login on the login page when enterprise integration is disabled. * Address review comments
openedx-webhooks
added
needs triage
open-source-contribution
|
Thanks for the pull request, @cmltaWt0! I've created OSPR-5835 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Contributor
|
@cmltaWt0 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
dmitry-viskov
pushed a commit
to weaveeducation/edx-platform
that referenced
this pull request
Jun 8, 2021
…openedx#27130) (openedx#27834) * fix: Hide enterprise/login button if enterprise integration disabled. [BTR-52](https://openedx.atlassian.net/browse/BTR-52) Fix an issue with existing button for enterprise login on the login page when enterprise integration is disabled. Co-authored-by: Igor Degtiarov <igor.degtiarov@raccoongang.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport for https://github.com/edx/edx-platform/pull/27130 to Lilac.master
Description:
Fix an issue with an existing button for enterprise login on the login page
when enterprise integration is disabled.
Jira
BTR issue