refactor!: Using Waffle flag to enable Account MFE globally. - #27623
Merged
robrap merged 1 commit intoMay 18, 2021
Merged
Conversation
This commit refactors the way the Account MFE is activated in the platform. The main objective is to control the global activation/deactivation of the MFE through the account.redirect_to_microfrontend waffle flag and use the Site Configurations to control MFE activation/deactivation with per-site granularity. Notice that the Site Configuration object will have precedence over the waffle flag value. Since the classic Account Django view will be most likely supported during Lilac, the expiration of this temporary waffle flag was extended till the end of 2021 With this commit: - There's no need to create a Site Configuration object to get the MFE activated. Setting the waffle flag to True is enough. - It helps multisite installations to better handling granular per-site activation/deactivation. BREAKING CHANGE: For operators of multisite installations, the activation of the waffle flag will now activate the MFE for all sites, unless explicitly disabled on a per-site basis. Otherwise, this is a backwards-compatible change, since the MFE will remain activated for installations where this is already enabled.
|
Thanks for the pull request, @ericfab179! I've created OSPR-5779 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
needs triage
open-source-contribution
Contributor
|
@nedbat do we need a PR for this backport? or you can apply the cherry-pick? |
robrap
approved these changes
May 18, 2021
|
@ericfab179 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
sambapete
added a commit
to EDUlib/edx-platform
that referenced
this pull request
May 19, 2021
…_global… …ly_backport refactor!: Using Waffle flag to enable Account MFE globally.
Contributor
|
@ericfab179 @robrap Thank you both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #27518
Related BTR issue openedx/wg-build-test-release#27