fix: only show 'View in New Exp.' to global staff if MFE preview enabled - #27467
Merged
kdmccormick merged 1 commit intoMay 10, 2021
Conversation
Since the ENABLE_COURSEWARE_MICROFRONTEND Django setting was removed, the "View in New Experience" button began to always appear in Legacy courseware for global staff members in *all* environments. This was OK for edx.org's purposes, since the Learning MFE is deployed in all of our production environments. However, many (perhaps most) Lilac Open edX instances will *not* deploy the Learning MFE. So, we need to make sure that this button is not shown by default. Since we cannot programmatically tell from LMS whether or not the Learning MFE is deployed, we will depend on the value of the `courseware.microfrontend_course_team_preview` flag, which is already being used to decide whether course staff can see the "View in New Experience" button. Whether or not the button is shown, global staff will still be permitted to browse courses in the Learning MFE if it is deployed. openedx/wg-build-test-release#49
kdmccormick
marked this pull request as ready for review
April 28, 2021 19:37
Member
Author
|
Hey @arbrandes, will someone on BTR be reviewing this, or should I have one my of team members take a look? |
regisb
approved these changes
May 10, 2021
Contributor
|
Thanks @kdmccormick and @regisb! |
sambapete
added a commit
to EDUlib/edx-platform
that referenced
this pull request
May 13, 2021
…led (openedx#27467) Since the ENABLE_COURSEWARE_MICROFRONTEND Django setting was removed, the "View in New Experience" button began to always appear in Legacy courseware for global staff members in *all* environments. This was OK for edx.org's purposes, since the Learning MFE is deployed in all of our production environments. However, many (perhaps most) Lilac Open edX instances will *not* deploy the Learning MFE. So, we need to make sure that this button is not shown by default. Since we cannot programmatically tell from LMS whether or not the Learning MFE is deployed, we will depend on the value of the `courseware.microfrontend_course_team_preview` flag, which is already being used to decide whether course staff can see the "View in New Experience" button. Whether or not the button is shown, global staff will still be permitted to browse courses in the Learning MFE if it is deployed. openedx/wg-build-test-release#49 Backported from master
sambapete
added a commit
to EDUlib/edx-platform
that referenced
this pull request
May 24, 2021
…led (openedx#27467) Since the ENABLE_COURSEWARE_MICROFRONTEND Django setting was removed, the "View in New Experience" button began to always appear in Legacy courseware for global staff members in *all* environments. This was OK for edx.org's purposes, since the Learning MFE is deployed in all of our production environments. However, many (perhaps most) Lilac Open edX instances will *not* deploy the Learning MFE. So, we need to make sure that this button is not shown by default. Since we cannot programmatically tell from LMS whether or not the Learning MFE is deployed, we will depend on the value of the `courseware.microfrontend_course_team_preview` flag, which is already being used to decide whether course staff can see the "View in New Experience" button. Whether or not the button is shown, global staff will still be permitted to browse courses in the Learning MFE if it is deployed. openedx/wg-build-test-release#49 Backported from master
sambapete
added a commit
to EDUlib/edx-platform
that referenced
this pull request
Jun 9, 2021
…led (openedx#27467) Since the ENABLE_COURSEWARE_MICROFRONTEND Django setting was removed, the "View in New Experience" button began to always appear in Legacy courseware for global staff members in *all* environments. This was OK for edx.org's purposes, since the Learning MFE is deployed in all of our production environments. However, many (perhaps most) Lilac Open edX instances will *not* deploy the Learning MFE. So, we need to make sure that this button is not shown by default. Since we cannot programmatically tell from LMS whether or not the Learning MFE is deployed, we will depend on the value of the `courseware.microfrontend_course_team_preview` flag, which is already being used to decide whether course staff can see the "View in New Experience" button. Whether or not the button is shown, global staff will still be permitted to browse courses in the Learning MFE if it is deployed. openedx/wg-build-test-release#49 Backported from master
sambapete
added a commit
to EDUlib/edx-platform
that referenced
this pull request
Jun 9, 2021
…led (openedx#27467) after rebase for lilac.1 Since the ENABLE_COURSEWARE_MICROFRONTEND Django setting was removed, the "View in New Experience" button began to always appear in Legacy courseware for global staff members in *all* environments. This was OK for edx.org's purposes, since the Learning MFE is deployed in all of our production environments. However, many (perhaps most) Lilac Open edX instances will *not* deploy the Learning MFE. So, we need to make sure that this button is not shown by default. Since we cannot programmatically tell from LMS whether or not the Learning MFE is deployed, we will depend on the value of the `courseware.microfrontend_course_team_preview` flag, which is already being used to decide whether course staff can see the "View in New Experience" button. Whether or not the button is shown, global staff will still be permitted to browse courses in the Learning MFE if it is deployed. openedx/wg-build-test-release#49 Backported from master
sambapete
added a commit
to EDUlib/edx-platform
that referenced
this pull request
Aug 9, 2021
…led (openedx#27467) Since the ENABLE_COURSEWARE_MICROFRONTEND Django setting was removed, the "View in New Experience" button began to always appear in Legacy courseware for global staff members in *all* environments. This was OK for edx.org's purposes, since the Learning MFE is deployed in all of our production environments. However, many (perhaps most) Lilac Open edX instances will *not* deploy the Learning MFE. So, we need to make sure that this button is not shown by default. Since we cannot programmatically tell from LMS whether or not the Learning MFE is deployed, we will depend on the value of the `courseware.microfrontend_course_team_preview` flag, which is already being used to decide whether course staff can see the "View in New Experience" button. Whether or not the button is shown, global staff will still be permitted to browse courses in the Learning MFE if it is deployed. openedx/wg-build-test-release#49 Backported from master
sambapete
added a commit
to EDUlib/edx-platform
that referenced
this pull request
Aug 11, 2021
…led (openedx#27467) Since the ENABLE_COURSEWARE_MICROFRONTEND Django setting was removed, the "View in New Experience" button began to always appear in Legacy courseware for global staff members in *all* environments. This was OK for edx.org's purposes, since the Learning MFE is deployed in all of our production environments. However, many (perhaps most) Lilac Open edX instances will *not* deploy the Learning MFE. So, we need to make sure that this button is not shown by default. Since we cannot programmatically tell from LMS whether or not the Learning MFE is deployed, we will depend on the value of the `courseware.microfrontend_course_team_preview` flag, which is already being used to decide whether course staff can see the "View in New Experience" button. Whether or not the button is shown, global staff will still be permitted to browse courses in the Learning MFE if it is deployed. openedx/wg-build-test-release#49 Backported from master
sambapete
added a commit
to EDUlib/edx-platform
that referenced
this pull request
Jan 6, 2022
…led (openedx#27467) Since the ENABLE_COURSEWARE_MICROFRONTEND Django setting was removed, the "View in New Experience" button began to always appear in Legacy courseware for global staff members in *all* environments. This was OK for edx.org's purposes, since the Learning MFE is deployed in all of our production environments. However, many (perhaps most) Lilac Open edX instances will *not* deploy the Learning MFE. So, we need to make sure that this button is not shown by default. Since we cannot programmatically tell from LMS whether or not the Learning MFE is deployed, we will depend on the value of the `courseware.microfrontend_course_team_preview` flag, which is already being used to decide whether course staff can see the "View in New Experience" button. Whether or not the button is shown, global staff will still be permitted to browse courses in the Learning MFE if it is deployed. openedx/wg-build-test-release#49 Backported from master
sambapete
added a commit
to EDUlib/edx-platform
that referenced
this pull request
Jan 6, 2022
…led (openedx#27467) Since the ENABLE_COURSEWARE_MICROFRONTEND Django setting was removed, the "View in New Experience" button began to always appear in Legacy courseware for global staff members in *all* environments. This was OK for edx.org's purposes, since the Learning MFE is deployed in all of our production environments. However, many (perhaps most) Lilac Open edX instances will *not* deploy the Learning MFE. So, we need to make sure that this button is not shown by default. Since we cannot programmatically tell from LMS whether or not the Learning MFE is deployed, we will depend on the value of the `courseware.microfrontend_course_team_preview` flag, which is already being used to decide whether course staff can see the "View in New Experience" button. Whether or not the button is shown, global staff will still be permitted to browse courses in the Learning MFE if it is deployed. openedx/wg-build-test-release#49 Backported from master
sambapete
added a commit
to EDUlib/edx-platform
that referenced
this pull request
Jan 7, 2022
…led (openedx#27467) Since the ENABLE_COURSEWARE_MICROFRONTEND Django setting was removed, the "View in New Experience" button began to always appear in Legacy courseware for global staff members in *all* environments. This was OK for edx.org's purposes, since the Learning MFE is deployed in all of our production environments. However, many (perhaps most) Lilac Open edX instances will *not* deploy the Learning MFE. So, we need to make sure that this button is not shown by default. Since we cannot programmatically tell from LMS whether or not the Learning MFE is deployed, we will depend on the value of the `courseware.microfrontend_course_team_preview` flag, which is already being used to decide whether course staff can see the "View in New Experience" button. Whether or not the button is shown, global staff will still be permitted to browse courses in the Learning MFE if it is deployed. openedx/wg-build-test-release#49 Backported from master
sambapete
added a commit
to EDUlib/edx-platform
that referenced
this pull request
Jan 7, 2022
…led (openedx#27467) Since the ENABLE_COURSEWARE_MICROFRONTEND Django setting was removed, the "View in New Experience" button began to always appear in Legacy courseware for global staff members in *all* environments. This was OK for edx.org's purposes, since the Learning MFE is deployed in all of our production environments. However, many (perhaps most) Lilac Open edX instances will *not* deploy the Learning MFE. So, we need to make sure that this button is not shown by default. Since we cannot programmatically tell from LMS whether or not the Learning MFE is deployed, we will depend on the value of the `courseware.microfrontend_course_team_preview` flag, which is already being used to decide whether course staff can see the "View in New Experience" button. Whether or not the button is shown, global staff will still be permitted to browse courses in the Learning MFE if it is deployed. openedx/wg-build-test-release#49 Backported from master
sambapete
added a commit
to EDUlib/edx-platform
that referenced
this pull request
Feb 11, 2022
…led (openedx#27467) Since the ENABLE_COURSEWARE_MICROFRONTEND Django setting was removed, the "View in New Experience" button began to always appear in Legacy courseware for global staff members in *all* environments. This was OK for edx.org's purposes, since the Learning MFE is deployed in all of our production environments. However, many (perhaps most) Lilac Open edX instances will *not* deploy the Learning MFE. So, we need to make sure that this button is not shown by default. Since we cannot programmatically tell from LMS whether or not the Learning MFE is deployed, we will depend on the value of the `courseware.microfrontend_course_team_preview` flag, which is already being used to decide whether course staff can see the "View in New Experience" button. Whether or not the button is shown, global staff will still be permitted to browse courses in the Learning MFE if it is deployed. openedx/wg-build-test-release#49 Backported from master
sambapete
added a commit
to EDUlib/edx-platform
that referenced
this pull request
Feb 11, 2022
…led (openedx#27467) Since the ENABLE_COURSEWARE_MICROFRONTEND Django setting was removed, the "View in New Experience" button began to always appear in Legacy courseware for global staff members in *all* environments. This was OK for edx.org's purposes, since the Learning MFE is deployed in all of our production environments. However, many (perhaps most) Lilac Open edX instances will *not* deploy the Learning MFE. So, we need to make sure that this button is not shown by default. Since we cannot programmatically tell from LMS whether or not the Learning MFE is deployed, we will depend on the value of the `courseware.microfrontend_course_team_preview` flag, which is already being used to decide whether course staff can see the "View in New Experience" button. Whether or not the button is shown, global staff will still be permitted to browse courses in the Learning MFE if it is deployed. openedx/wg-build-test-release#49 Backported from master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of https://github.com/edx/edx-platform/pull/27399
Resolves openedx/wg-build-test-release#49
I confirmed that the affected files still pass
pycodestyle,pylint, andpytestwhen cherry-picked onto Lilac master.I confirmed that the fix works in devstack when cherry-picked onto Lilac master.