Skip to content

feat: AA-741: Enables the dates tab for all enrolled learners - #27402

Merged
Dillon-Dumesnil merged 1 commit into
open-release/lilac.masterfrom
ddumesnil/enable-dates-tab-aa-741
Apr 26, 2021
Merged

feat: AA-741: Enables the dates tab for all enrolled learners#27402
Dillon-Dumesnil merged 1 commit into
open-release/lilac.masterfrom
ddumesnil/enable-dates-tab-aa-741

Conversation

@Dillon-Dumesnil

@Dillon-Dumesnil Dillon-Dumesnil commented Apr 22, 2021

Copy link
Copy Markdown
Contributor

Removes the relative dates flag check as it is no longer
necessary to show the dates tab

Corresponding PR to master https://github.com/edx/edx-platform/pull/27401

Removes the relative dates flag check as it is no longer
necessary to show the dates tab
@Dillon-Dumesnil
Dillon-Dumesnil force-pushed the ddumesnil/enable-dates-tab-aa-741 branch from 80795d8 to 0a08852 Compare April 22, 2021 19:22

@MatthewPiatetsky MatthewPiatetsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does anything need to be added to release notes?

@Dillon-Dumesnil

Copy link
Copy Markdown
Contributor Author

The Lilac release notes specify the dates tab, but I added a note that we removed the check of relative dates.

@nedbat

nedbat commented Apr 22, 2021

Copy link
Copy Markdown
Contributor

Thanks for making a Lilac fix. Is there a corresponding pull request against master? It might make it easier for us in the future if it's noted here.

@Dillon-Dumesnil

Copy link
Copy Markdown
Contributor Author

@nedbat I updated the top level description to include a reference to the PR to master.

@Dillon-Dumesnil
Dillon-Dumesnil merged commit bfef207 into open-release/lilac.master Apr 26, 2021
@Dillon-Dumesnil
Dillon-Dumesnil deleted the ddumesnil/enable-dates-tab-aa-741 branch April 26, 2021 17:56
sambapete added a commit to EDUlib/edx-platform that referenced this pull request Apr 30, 2021
…aa-741

feat: AA-741: Enables the dates tab for all enrolled learners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants