Revert "perf: avoid invoking codejail for problem response report" - #27310
Merged
ormsbee merged 1 commit intoApr 12, 2021
Merged
Conversation
This reverts commit 35b2780.
kdmccormick
approved these changes
Apr 12, 2021
doctoryes
approved these changes
Apr 12, 2021
doctoryes
left a comment
doctoryes
left a comment
Contributor
There was a problem hiding this comment.
Ugh - seemed like a sound solution. 👍🏼
|
Your PR has finished running tests. There were no failures. |
ormsbee
deleted the
revert-27271-ormsbee/problem-report-without-codejail
branch
April 12, 2021 21:17
nedbat
pushed a commit
that referenced
this pull request
Jul 16, 2021
dmitry-viskov
pushed a commit
to weaveeducation/edx-platform
that referenced
this pull request
Sep 22, 2021
…penedx#27310) (openedx#28206) This reverts commit 35b2780.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts edx/edx-platform#27271
This is to fix TNL-8220, an error when running the problem response
report with multiple choice problems, because that would attempt to
extract the answer text in find_answer_text, which will not yield the
correct result without the processing that minimal_init bypasses.