add some rate limiting to the password reset functionality - #2711
Conversation
|
@chrisndodge 3rd party not needed to be added to requirements ? |
|
This is already in use in the stack, I'm just re-using it. |
There was a problem hiding this comment.
Instead of instantiating a Mixin class, and duplicating code from ratelimitbackend/backends.py, can we create a reusable class that lets us add rate limiting in a more modular way? Looks like a .request_allowed(request) method and a .bad_request(request) method would do the trick. It's too bad the ratelimitbackend wasn't written this way to start with.
|
@nedbat, better? |
There was a problem hiding this comment.
Love the refactor, thanks! Did you mean for this to say "is rated limit exceeded", or "is rate limit exceeded"?
|
@chrisndodge looks good. Fix the function name if you meant it the other way, then merge it. 👍 |
add some rate limiting to the password reset functionality
…-2654-7 openedx#2654 Add module category to manage status. add test code.
3 participants
This uses the same 3rd party rate limiting library as is used in the login paths.
@dianakhuang can you take a look?