Next gen modulestore - #271
Merged
Merged
Conversation
Contributor
|
@cpennington @chrisndodge @cahrens Please review. |
|
The net change link doesn't seem to be working (to see diff just between removing templates and this pull request). |
Contributor
Author
There was a problem hiding this comment.
We didn't follow the factory_boy build vs create pattern because we didn't have a way of building non-persisted XModules, I suspect. Now that you have such a way, I'd rather make our factories better behaved, rather than have Persistent*Factories.
A new modulestore backed by mongo that changes the data format to facilitate easy versioning, sharing content between courses, and fast lookup of course structure and Scope.settings data. Conflicts: cms/djangoapps/contentstore/tests/test_contentstore.py
Contributor
Author
|
I'm merging this despite it being unstable, because otherwise it will develop more code drift. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dmitchell: Please validate commits and find reviewers
Builds on #270 (net change: edx/edx-platform@dhm/non-persisted-studio-templates...dhm/next-gen-modulestore)