refactor static tab tests - #2704
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Can you include a path to the file on disk where that text should appear?
On a more general note, is it possible to create these files in the setUp method, and clean them up in the tearDown method? That's really what these methods are for, not for assigning arbitrary constants and referring to them.
Contributor
|
@adampalay I'm seeing test failures on this branch. Can you look into it? |
Contributor
Author
|
@singingwolfboy , ready for review round 2 |
Contributor
|
👍 |
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jun 21, 2019
…-2654-8 openedx#2654 fix save register condition when not exist active condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@singingwolfboy