add new feature to make sure we aren't writing PII into the application ... - #2668
Merged
Conversation
Contributor
Author
Contributor
Author
|
OK, spoke too soon. Need to update shib_test since the change to .format() changed the number of arguments into the logging function. |
Contributor
Author
There was a problem hiding this comment.
I think user_found_by_email_lookup can't be None here, but it's not readily apparent. Is it possible to assuage my paranoia and explicitly handle that case?
Contributor
Author
|
@jbau better? |
|
yes, better. 👍 |
…on logs. So far we're aware of doing so regarding Auth use-cases
Contributor
Author
|
@jzoldak can I get your thumbs up as well? Or should I get another reviewer, like @dianakhuang or someone else from LMS team? |
Contributor
|
👍 |
chrisndodge
pushed a commit
that referenced
this pull request
Feb 26, 2014
add new feature to make sure we aren't writing PII into the application ...
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jun 21, 2019
…-2654-3 openedx#2654 マイページリンクの追加
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...logs. So far we're aware of doing so regarding Auth use-cases